Re: [PATCH v11 6/9] imap-send: fix minor mistakes in the logs

From: Aditya Garg <gargaditya08@live.com>
Date: Jun 2, 2025, 03:41 UTC
Message-ID: <PN3PR01MB9597F8C2F0A8F38225B9CF96B862A@PN3PR01MB9597.INDPRD01.PROD.OUTLOOK.COM>
In-Reply-To: <xmqq8qmbvurr.fsf@gitster.g>

Show 14 quoted lines

> On 2 Jun 2025, at 6:12 AM, Junio C Hamano <gitster@pobox.com> wrote:
> 
> Aditya Garg <gargaditya08@live.com> writes:
> 
>> Some minor mistakes have been found in the logs. Most of them include
>> error messages starting with a capital letter, and ending with a period.
>> Also, abbreviations like "IMAP" and "OK" should be in uppercase. Fix them.
>> 
>> Signed-off-by: Aditya Garg <gargaditya08@live.com>
>> ---
>> imap-send.c | 28 ++++++++++++++--------------
>> 1 file changed, 14 insertions(+), 14 deletions(-)
> 
> Quite honestly, I am not sure if this churn is worth it.

It was a significantly long patch before Eric's review, even I was thinking about dropping it. Then I saw the amount of conflicts it will cause .......

I think its just fine to keep it, its not causing anything degrading.