[PATCH v18 08/10] imap-send: display port alongwith host when git credential is invoked
- From
Aditya Garg <gargaditya08@live.com>
- Date
- Jun 9, 2025, 20:22 UTC
- Message-ID
- <PN3PR01MB95979FE054BDCB5452DB446BB86BA@PN3PR01MB9597.INDPRD01.PROD.OUTLOOK.COM>
- In-Reply-To
- <PN3PR01MB9597929CF956CBB1B8B7D909B86BA@PN3PR01MB9597.INDPRD01.PROD.OUTLOOK.COM>
When requesting for passsword, git credential helper used to display only the host name. For example:
Password for 'imaps://gargaditya08%40live.com@outlook.office365.com':
Now, it will display the port along with the host name:
Password for 'imaps://gargaditya08%40live.com@outlook.office365.com:993':
This has been done to make credential helpers more specific for ports. Also, this behaviour will also mimic git send-email, which displays the port along with the host name when requesting for a password.
Signed-off-by: Aditya Garg <gargaditya08@live.com> --- imap-send.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/imap-send.c b/imap-send.c index 77cf2b3da2..a79e7c7da7 100644 --- a/imap-send.c +++ b/imap-send.c @@ -1089,7 +1089,7 @@ static void server_fill_credential(struct imap_server_conf *srvc, struct credent return; cred->protocol = xstrdup(srvc->use_ssl ? "imaps" : "imap"); - cred->host = xstrdup(srvc->host); + cred->host = xstrfmt("%s:%d", srvc->host, srvc->port); cred->username = xstrdup_or_null(srvc->user); cred->password = xstrdup_or_null(srvc->pass);
-- 2.49.0