Re: [PATCH 1/2] imap-send: fix bug causing cfg->folder being set to NULL
- From
Aditya Garg <gargaditya08@live.com>
- Date
- May 22, 2025, 19:04 UTC
- Message-ID
- <PN3PR01MB9597F896FE350C83D2A8821EB899A@PN3PR01MB9597.INDPRD01.PROD.OUTLOOK.COM>
- In-Reply-To
- <xmqqldqo5uzm.fsf@gitster.g>
On 23-05-2025 12:32 am, Junio C Hamano wrote:
Show 15 quoted lines
> Eric Sunshine <sunshine@sunshineco.com> writes: > >> Okay, makes sense. It might be worth mentioning in the commit message >> that these copy/paste bugs were introduced by 6d1f198f34 (imap-send: >> fix leaking memory in `imap_server_conf`, 2024-06-07). > > Definitely a good thing to note in the message, together with the > subtlety that the bug is dependenty on the order in which these > configuration variables appear in the file. > > In any case, this may indicate that the population of those who > tried to use imap-send since mid last year, whether they used to use > it happily before last year or they tried to use it anew, must be > very small, or we would have heard about this obvious gotcha by now. >
I also just managed to use OAuth2.0 with curl, apparently curl has dedicated API for this.
Will send a v2 with that fix as well.