Re: [PATCH v16 03/10] imap-send: gracefully fail if CRAM-MD5 authentication is requested without OpenSSL

From: Aditya Garg <gargaditya08@live.com>
Date: Jun 9, 2025, 19:20 UTC
Message-ID: <PN3PR01MB959747D02A97954CE46F4F27B86BA@PN3PR01MB9597.INDPRD01.PROD.OUTLOOK.COM>
In-Reply-To: <xmqqzfegpvyu.fsf@gitster.g>

Show 16 quoted lines

> On 10 Jun 2025, at 12:46 AM, Junio C Hamano <gitster@pobox.com> wrote:
> 
> Aditya Garg <gargaditya08@live.com> writes:
> 
>> +                if (try_auth_method(srvc, ctx, imap, "CRAM-MD5", AUTH_CRAM_MD5, auth_cram_md5))
>>                    goto bail;
>> -                }
>>            } else {
>>                fprintf(stderr, "Unknown authentication method:%s\n", srvc->host);
>>                goto bail;
> 
> Outside the theme of this step (read: I am only leaving a mental
> note as potential #leftoverbits; I do not want to see this fixed as
> part of this step) and probably outside the theme of this series,
> but srvc->host is probably copy-and-paste-bug for srvc->auth_method
> I would think.

Good catch. I can make this minor change a part of v18.