Re: [PATCH v19 00/10] imap-send: make it usable again and add OAuth2.0 support

From: Phillip Wood <phillip.wood123@gmail.com>
Date: Jun 23, 2025, 09:09 UTC
Message-ID: <c787a41c-97c6-437f-aae0-52132c79db7c@gmail.com>
In-Reply-To: <xmqqh60a4dk6.fsf@gitster.g>

On 20/06/2025 16:50, Junio C Hamano wrote:

Show 25 quoted lines

> Aditya Garg <gargaditya08@live.com> writes:
> 
>> v19: - Use xstrfmt() for OAuth2 strings and strbuf for PLAIN.
>>
>> Aditya Garg (10):
>>    imap-send: fix bug causing cfg->folder being set to NULL
>>    imap-send: fix memory leak in case auth_cram_md5 fails
>>    imap-send: gracefully fail if CRAM-MD5 authentication is requested
>>      without OpenSSL
>>    imap-send: add support for OAuth2.0 authentication
>>    imap-send: add PLAIN authentication method to OpenSSL
>>    imap-send: enable specifying the folder using the command line
>>    imap-send: add ability to list the available folders
>>    imap-send: display port alongwith host when git credential is invoked
>>    imap-send: display the destination mailbox when sending a message
>>    imap-send: fix minor mistakes in the logs
>>
>>   Documentation/config/imap.adoc   |  11 +-
>>   Documentation/git-imap-send.adoc |  68 +++++-
>>   imap-send.c                      | 405 ++++++++++++++++++++++++++-----
>>   3 files changed, 407 insertions(+), 77 deletions(-)
> 
> Looking good.  Will replace.
> 
> Should we declare victory and mark the topic for 'next' now?

I think so, the range diff looks good. I've not reviewed each patch but I just had a quick scan of

     git diff origin/master origin/seen imap-send.c

and it looked reasonable.

Best Wishes

Phillip