Re: [PATCH v7 23/28] Reftable support for git-core

From: Junio C Hamano <gitster@pobox.com>
Date: Apr 21, 2021, 23:22 UTC
Message-ID: <xmqqeef3xlxg.fsf@gitster.g>
In-Reply-To: <CAFQ2z_Nm4Mixhi0kXTdN+nVj412_WPe=k9v6FpJFyaOx9qMRUA@mail.gmail.com>

Han-Wen Nienhuys <hanwen@google.com> writes:

Show 13 quoted lines

>> IOW, do you want the above to read
>>
>>         if test -n "$GIT_TEST_REFTABLE"
>>         then
>>                 test_set_prereq REFTABLE
>>         else
>>                 test_set_prereq REFFILES
>>         fi
>>
>> when both series are in effect?
>
> Yes, but on 2nd thought it's probably better to stick with just
> REFFILES, and rewrite any reftable specific tests as !REFFILES.

I guess that is both good enough and simpler. The only possible downside is that it would be cumbersome if we ever need to support the third ref backend, but I expect that it won't happen before the reftable support solidifies, and under that assumption, the simpler the better.

Thanks.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.