Re: [PATCH v2 12/13] reftable: rest of library

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Oct 4, 2020, 18:39 UTC
Message-ID: <nycvar.QRO.7.76.6.2010042036221.50@tvgsbejvaqbjf.bet>
In-Reply-To: <xmqqzh548sid.fsf@gitster.c.googlers.com>

Hi Junio,

On Fri, 2 Oct 2020, Junio C Hamano wrote:

Show 9 quoted lines

> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
>
> > Subject: [PATCH 3/3] fixup??? reftable: rest of library
> >
> > Avoid using `getopt()`: it might be POSIX, but Git's audience is much
> > larger than POSIX. MSVC, for example, does not support `getopt()`.
>
> Either that, or we could use parse-options().  I do not care either
> way, as this seems to be purely for debugging?

I actually wanted to use `parse_options()`, but due to the way `reftable/` insists on being completely separate from `libgit.a`, it is not really trivial, as `#include "parse-options.h"` fails (because `git-compat-util.h` was not included, and IIRC including _that_ resulted in more compile errors, at which stage I opted for a more minimal solution).

So yeah, I would strongly expect `reftable/` to become considerably simpler once it starts using `libgit.a`'s goodies.

Ciao, Dscho