Re: [PATCH v6 04/20] reftable: utility functions
- From
Han-Wen Nienhuys <hanwen@google.com>
- Date
- Apr 15, 2021, 15:00 UTC
- Message-ID
- <CAFQ2z_MaqYTWr2haHVF=oiSbYCct+oFpdwD+VtnpKKMFNgvkJg@mail.gmail.com>
- In-Reply-To
- <87r1je2up2.fsf@evledraar.gmail.com>
On Tue, Apr 13, 2021 at 3:14 PM Ævar Arnfjörð Bjarmason <avarab@gmail.com> wrote:
Show 8 quoted lines
> I'd think that rather than duplicating magic constants & one thing in > dir.h we'd be better off having some leading patches splitting off the > relevant parts of object-file.c & dir.h, maybe THAT_NAME_minimal.h? > > Or: why not simply include dir.h and object.h etc? The compiler/linker > will discard the unused functions, and if the worry is overuse of > git.git functions creeping in I'd think that would be better done via > some test/CI job that checks what objects were used.
It was useful to see how much (or how little) of Git I needed to make it work, but it has served its purpose, so I followed your suggestion to use dir.h and object.h.
-- Han-Wen Nienhuys - Google Munich I work 80%. Don't expect answers from me on Fridays. -- Google Germany GmbH, Erika-Mann-Strasse 33, 80636 Munich Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Geschäftsführer: Paul Manicle, Halimah DeLaine Prado