Re: [PATCH v6 07/20] reftable: reading/writing blocks

From: Han-Wen Nienhuys <hanwen@google.com>
Date: Apr 15, 2021, 08:57 UTC
Message-ID: <CAFQ2z_NusDzvVUjm7+pyuBc9wosuLD+rUdDwLO=hQbiRTs08PA@mail.gmail.com>
In-Reply-To: <87a6q2egvy.fsf@evledraar.gmail.com>

On Tue, Apr 13, 2021 at 10:19 AM Ævar Arnfjörð Bjarmason <avarab@gmail.com> wrote:

Show 11 quoted lines

> > Includes a code snippet copied from zlib
> > [...]
> > +int ZEXPORT uncompress_return_consumed (
>
> Pending the "how is this integrated?" question I had in
> http://lore.kernel.org/git/87fszuej8y.fsf@evledraar.gmail.com it's a bit
> odd to have a "compat" we unconditionally compile.
>
> Since this is for post-2017 zlib doesn't putting it in top-level
> compat/* and having a flag to enable it make more sense, and then not
> renaming the function.

Thanks. I've moved this into compat/ for the next version of the series

(how should I track this info. Is the email here fine, or do I somehow have to work this into the commit message?)

-- 
Han-Wen Nienhuys - Google Munich
I work 80%. Don't expect answers from me on Fridays.
--

Google Germany GmbH, Erika-Mann-Strasse 33, 80636 Munich

Registergericht und -nummer: Hamburg, HRB 86891

Sitz der Gesellschaft: Hamburg

Geschäftsführer: Paul Manicle, Halimah DeLaine Prado