Re: [PATCH v6 07/20] reftable: reading/writing blocks
- From
Ævar Arnfjörð Bjarmason <avarab@gmail.com>
- Date
- Apr 13, 2021, 08:19 UTC
- Message-ID
- <87a6q2egvy.fsf@evledraar.gmail.com>
- In-Reply-To
- <9297b9c363f6d922443d261375759046e303351d.1618255553.git.gitgitgadget@gmail.com>
On Mon, Apr 12 2021, Han-Wen Nienhuys via GitGitGadget wrote:
> Includes a code snippet copied from zlib > [...] > +int ZEXPORT uncompress_return_consumed (
Pending the "how is this integrated?" question I had in http://lore.kernel.org/git/87fszuej8y.fsf@evledraar.gmail.com it's a bit odd to have a "compat" we unconditionally compile.
Since this is for post-2017 zlib doesn't putting it in top-level compat/* and having a flag to enable it make more sense, and then not renaming the function.
Thus those who need it will have a symbol conflict when they upgrade their zlib to not need the compat wrapper, but that's a feature.
> + Bytef *dest, > + uLongf *destLen, > + const Bytef *source,
I see this is modified from upstream's which would trip our DEVELOPER=*-only -Wold-style-definition under -Werror. We have other disabling of flags for compat/* already, seems better to use the upstream source file as-is with that.