Re: [PATCH v3 04/16] reftable: add error related functionality

From: Felipe Contreras <felipe.contreras@gmail.com>
Date: Nov 27, 2020, 09:13 UTC
Message-ID: <CAMP44s1EhqDf4_T1zLC8iXA32P1atVMW-AnP=EJ3eXTzUbnU8w@mail.gmail.com>
In-Reply-To: <2aa30f536fb7ce5501d1ecf0315cbcb1c1c5ce38.1606419752.git.gitgitgadget@gmail.com>

On Fri, Nov 27, 2020 at 2:42 AM Han-Wen Nienhuys via GitGitGadget <gitgitgadget@gmail.com> wrote:

> +/*
> + Errors in reftable calls are signaled with negative integer return values. 0
> + means success.
> +*/

This is the format of multi-line comments:

/*
* A very long
* multi-line comment.
*/

Show 6 quoted lines

> +enum reftable_error {
> +       /* Unexpected file system behavior */
> +       REFTABLE_IO_ERROR = -2,
> +
> +       /* Format inconsistency on reading data
> +        */

No need for a multi-line comment here.

Show 5 quoted lines

> +       REFTABLE_FORMAT_ERROR = -3,
> +
> +       /* File does not exist. Returned from block_source_from_file(),  because
> +          it needs special handling in stack.
> +       */

Once again, and for the rest of the file.

-- 
Felipe Contreras