Re: [PATCH v2 03/13] vcxproj: adjust for the reftable changes

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Oct 2, 2020, 11:43 UTC
Message-ID: <nycvar.QRO.7.76.6.2010021342200.50@tvgsbejvaqbjf.bet>
In-Reply-To: <20201002040200.GC3252492@google.com>

Hi Jonathan,

On Thu, 1 Oct 2020, Jonathan Nieder wrote:

Show 19 quoted lines

> Han-Wen Nienhuys wrote:
>
> > From: Johannes Schindelin <johannes.schindelin@gmx.de>
> >
> > This allows Git to be compiled via Visual Studio again after integrating
> > the `hn/reftable` branch.
>
> nit: This branch name is no longer meaningful to the primary audience
> for the commit message (people discovering this commit in git history
> later).
>
> > Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
> > ---
> >  config.mak.uname                           |  2 +-
> >  contrib/buildsystems/Generators/Vcxproj.pm | 11 ++++++++++-
> >  2 files changed, 11 insertions(+), 2 deletions(-)
>
> Can this be squashed into or put immediately after patch 5 which
> introduces the Makefile?

I never intended this to be a stand-alone patch. So yes, I would be very much in favor of squashing these changes into the appropriate commit.

Ciao, Dscho