Re: [PATCH 0/4] hash.h: support choosing a separate SHA-1 for non-cryptographic uses

From: Junio C Hamano <gitster@pobox.com>
Date: Sep 5, 2024, 16:51 UTC
Message-ID: <xmqq34me3uyz.fsf@gitster.g>
In-Reply-To: <ZtnbFXL7W5DvW8UN@nand.local>

Taylor Blau <me@ttaylorr.com> writes:

> If so, I agree, but would note that this series does not yet switch
> index-pack to use the non-collision detecting SHA-1 implementation when
> available, so that would not be a prerequisite for merging this series.

Hmph, I am confused. It needs to be corrected in order to address collisions of the tail sum Peff raised, as no longer checked the tail sum with SHA1DC but with "fast" SHA-1.

Doesn't it make it a prerequisite?

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.