From: Junio C Hamano Date: Thu, 05 Sep 2024 16:51:00 GMT Subject: Re: [PATCH 0/4] hash.h: support choosing a separate SHA-1 for non-cryptographic uses Message-ID: In-Reply-To: Taylor Blau writes: > If so, I agree, but would note that this series does not yet switch > index-pack to use the non-collision detecting SHA-1 implementation when > available, so that would not be a prerequisite for merging this series. Hmph, I am confused. It needs to be corrected in order to address collisions of the tail sum Peff raised, as no longer checked the tail sum with SHA1DC but with "fast" SHA-1. Doesn't it make it a prerequisite?