Re: [PATCH 1/4] sha1: do not redefine `platform_SHA_CTX` and friends
- From
Taylor Blau <me@ttaylorr.com>
- Date
- Sep 3, 2024, 19:34 UTC
- Message-ID
- <ZtdkwtVt7wl887gL@nand.local>
- In-Reply-To
- <ZtXAgFfhaoTxF1tC@tanuki>
On Mon, Sep 02, 2024 at 03:41:20PM +0200, Patrick Steinhardt wrote:
> So we now pick the first hash we find as platform hash, whereas > previously we would have always picked the last one? Hum, okay. A bit > curious, but let's read on.
In a pre-_FAST SHA-1 environment, we only ever #include one of these to begin with, so the order doesn't matter. After this series, we may include two SHA-1 implementations, but we include the non-_FAST one first, so we'll always pick that one as the default platform implementation.
Thanks, Taylor