Re: [PATCH v5 0/8] hash.h: support choosing a separate SHA-1 for non-cryptographic uses

From: Jeff King <peff@peff.net>
Date: Sep 27, 2024, 03:57 UTC
Message-ID: <20240927035712.GH567395@coredump.intra.peff.net>
In-Reply-To: <cover.1727364141.git.me@ttaylorr.com>

On Thu, Sep 26, 2024 at 11:22:27AM -0400, Taylor Blau wrote:

Show 10 quoted lines

> Range-diff against v4:
> -:  ---------- > 1:  6f1ee91fff finalize_object_file(): check for name collision before renaming
> -:  ---------- > 2:  133047ca8c finalize_object_file(): refactor unlink_or_warn() placement
> 1:  ed9eeef851 ! 3:  41d38352a4 finalize_object_file(): implement collision check
> [...]
> 2:  3cc7f7b1f6 = 4:  611475d83e pack-objects: use finalize_object_file() to rename pack/idx/etc
> 3:  8f8ac0f5b0 = 5:  9913a5d971 sha1: do not redefine `platform_SHA_CTX` and friends
> 4:  d300e9c688 = 6:  65de6d724d hash.h: scaffolding for _unsafe hashing variants
> 5:  af8fd9aa4e = 7:  3884cd0e3a Makefile: allow specifying a SHA-1 for non-cryptographic uses
> 6:  4b83dd05e9 ! 8:  62abddf73d csum-file.c: use unsafe SHA-1 implementation when available

Funny range-diff, but I think those patches are here in the series as expected.

Anyway, the result looks good to me!

-Peff