Re: [PATCH 0/4] hash.h: support choosing a separate SHA-1 for non-cryptographic uses

From: Taylor Blau <me@ttaylorr.com>
Date: Sep 5, 2024, 20:21 UTC
Message-ID: <ZtoS0LYEZqfwvmtw@nand.local>
In-Reply-To: <ZtnvjlW3DotdK/lB@nand.local>

On Thu, Sep 05, 2024 at 01:51:10PM -0400, Taylor Blau wrote:

Show 14 quoted lines

> , fails very quickly and produces the following:
>
>     [main 727346d] foo
>     Enumerating objects: 12, done.
>     Counting objects: 100% (12/12), done.
>     Delta compression using up to 20 threads
>     Compressing objects: 100% (11/11), done.
>     Writing objects: 100% (12/12), 779 bytes | 779.00 KiB/s, done.
>     Total 12 (delta 10), reused 0 (delta 0), pack-reused 0 (from 0)
>     remote: fatal: final sha1 did not match
>     error: remote unpack failed: unpack-objects abnormal exit
>     To ../victim.git
>      ! [remote rejected] HEAD -> foo (unpacker error)
>     error: failed to push some refs to '../victim.git'

I didn't set transfer.unpackLimit to zero here, which is why this says "(unpacker error)". But if I did remember, it would instead say:

    remote: fatal: pack is corrupted (SHA1 mismatch)
    error: remote unpack failed: index-pack abnormal exit
    To ../victim.git
     ! [remote rejected] HEAD -> foo2 (unpacker error)
    error: failed to push some refs to '../victim.git'

So we're safe here whether or not you use the unpackLimit setting.

Thanks, Taylor