Re: [msysGit] [PATCH 10/12] Add ANSI control code emulation for the Windows console

From: Peter Harris <git@peter.is-a-geek.org>
Date: Jul 2, 2008, 19:32 UTC
Message-ID: <eaa105840807021232r17ca03f4y1487a7659eb04da4@mail.gmail.com>
In-Reply-To: <200807022117.38166.johannes.sixt@telecom.at>

On Wed, Jul 2, 2008 at 3:17 PM, Johannes Sixt wrote:

Show 7 quoted lines

> On Mittwoch, 2. Juli 2008, Steffen Prohaska wrote:
>> This adds only the minimum necessary to keep git pull/merge's diffstat from
>> wrapping. Notably absent is support for the K (erase) operation, and
>> support for POSIX write.
>
> If I understand the patch correctly, it won't affect output that goes to the
> pager; only text that goes directly to the console would be colored.

Yes, that is correct.

Note that an MSYS bash/rxvt is effectively considered a pager by this patch, since it fails the isatty() test. This is actually a good thing: MSYS has better ANSI support anyway.

Peter Harris