Re: [PATCH 06/12] connect: Fix custom ports with plink (Putty's ssh)

From: Steffen Prohaska <prohaska@zib.de>
Date: Jul 4, 2008, 09:29 UTC
Message-ID: <7188A895-D5B9-480E-8486-8A69B8861646@zib.de>
In-Reply-To: <7vod5euhw3.fsf@gitster.siamese.dyndns.org>

On Jul 4, 2008, at 11:18 AM, Junio C Hamano wrote:

Show 16 quoted lines

> Johannes Sixt <johannes.sixt@telecom.at> writes:
>
>> What about installing a wrapper script, plinkssh, that does this:
>>
>> #!/bin/bash
>>
>> if test "$1" = -p; then
>> 	port="-P $2"
>> 	shift; shift
>> fi
>>
>> exec plink $port "$@"
>>
>> and require plink users to set GIT_SSH=plinkssh?
>
> That's quite a nice solution with absolute minimum impact.

It has minimum impact on the source code of git. The same is not true, however, for the git user and the installer on Windows:

  - The proposed plinkssh requires that plink is in the PATH.  This is
    not necessarily the case on Windows.  If plink is not in the PATH,
    then the user needs to modify plinkssh.

  - The msysgit installer supports setting GIT_SSH to the full path
    of plink.  It automatically detects this path based on Putty's
    entries in the Windows registry.  If we choose the plinkssh
    solution the installer has to be modified.

Setting '-P' in connect.c would have some impact on the git source, but would avoid changes elsewhere.

	Steffen