Re: [PATCH] Ask for "git program" when asking for "git-program" over SSH connection

From: Junio C Hamano <gitster@pobox.com>
Date: Jun 25, 2008, 05:13 UTC
Message-ID: <7v4p7i6qs1.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <7v8wwu6qxr.fsf@gitster.siamese.dyndns.org>

Junio C Hamano <gitster@pobox.com> writes:

Show 12 quoted lines

> "Shawn O. Pearce" <spearce@spearce.org> writes:
>
>>> Any other suggestions that is workable?
>>
>> diff --git a/builtin-clone.c b/builtin-clone.c
>> index 5c5acb4..98d0f0f 100644
>> --- a/builtin-clone.c
>> +++ b/builtin-clone.c
>> @@ -37,7 +37,7 @@ static int option_quiet, option_no_checkout, option_bare;
>
> << a patch to conditionally change "git-program" default to "git program"
> snipped >>

Typofix: s/cond/uncond/;

> How would that help client that talk with git-daemon, unlike what I sent
> earlier?

If we force --upload-pack workaround to _everybody_ we are already lost.

Also I think the previous one still lets you work it around by giving a full path, like "/usr/local/bin/git-upload-pack", because "/usr" does not match "git-" ;-)