Re: [PATCH 1/2] help.c: Add support for htmldir relative to git_exec_path()

From: Steffen Prohaska <prohaska@zib.de>
Date: Jul 11, 2008, 07:27 UTC
Message-ID: <4668B2FF-2B2B-4221-8151-F0AEA681983C@zib.de>
In-Reply-To: <alpine.DEB.1.00.0807041334010.9925@racer>

On Jul 4, 2008, at 2:35 PM, Johannes Schindelin wrote:

Show 9 quoted lines

> On Fri, 4 Jul 2008, Junio C Hamano wrote:
>
>> Could you check if there are copy-and-pasted duplicated code you can
>> factor out before continuing this direction?
>
> Note also that Hannes tried very hard to get rid of those ugly "#ifdef
> __MINGW32__"s by declaring/overriding functions in git-compat-util.h.
>
> I think that is such a good practice that we should not stop here.

I'll send three patches that address Junio's and Dscho's comments:

  [PATCH 1/3] Move code interpreting path relative to exec-dir to new  
function system_path()
  [PATCH 2/3] help.c: Add support for htmldir relative to  
git_exec_path()
  [PATCH 3/3] help (Windows): Display HTML in default browser using  
Windows' shell API

Hannes, the patches I'll send probably conflict with your planned work on GIT_EXEC_PATH that has been discussed on the msysgit list. I think you could built on my series and modify system_path().

	Steffen