Re: [PATCH] Make clients ask for "git program" over ssh and local transport
- From
Shawn O. Pearce <spearce@spearce.org>
- Date
- Jun 25, 2008, 23:13 UTC
- Message-ID
- <20080625231343.GS11793@spearce.org>
- In-Reply-To
- <7vvdzxw2eo.fsf_-_@gitster.siamese.dyndns.org>
Junio C Hamano <gitster@pobox.com> wrote:
Show 9 quoted lines
> This will allow server side programs such as upload-pack to be installed > outside $PATH. Connections to git-daemon still ask for "git-program" to > retain backward compatibility for daemons before 1.5.6.1 and 1.6.0. > > Signed-off-by: Junio C Hamano <gitster@pobox.com> > --- > * This is essentially your patch. This can be in 1.6.0 clients and it > should also be in 1.5.6.1 as people might keep ancient clients to talk > to new servers that won't have anything but "git" on $PATH.
Ack. Thanks for cleaning up the code in connect.c to not segfault or send garbage.
I think you want to squash this in as well:
diff --git a/builtin-send-pack.c b/builtin-send-pack.c index d76260c..f693a6d 100644 --- a/builtin-send-pack.c +++ b/builtin-send-pack.c @@ -12,7 +12,7 @@ static const char send_pack_usage[] = " --all and explicit <ref> specification are mutually exclusive."; static struct send_pack_args args = { - /* .receivepack = */ "git-receive-pack", + /* .receivepack = */ "git receive-pack", }; /*
-- Shawn.