Re: [PATCH 08/12] fast-import: MinGW does not have getppid(). So do not print it.
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Jul 2, 2008, 16:52 UTC
- Message-ID
- <alpine.DEB.1.00.0807021741210.9925@racer>
- In-Reply-To
- <7vzlp0bq2l.fsf@gitster.siamese.dyndns.org>
Hi,
On Wed, 2 Jul 2008, Junio C Hamano wrote:
Show 26 quoted lines
> Steffen Prohaska <prohaska@zib.de> writes:
>
> > diff --git a/fast-import.c b/fast-import.c
> > index e72b286..271b93c 100644
> > --- a/fast-import.c
> > +++ b/fast-import.c
> > @@ -391,7 +391,9 @@ static void write_crash_report(const char *err)
> >
> > fprintf(rpt, "fast-import crash report:\n");
> > fprintf(rpt, " fast-import process: %d\n", getpid());
> > +#ifndef __MINGW32__
> > fprintf(rpt, " parent process : %d\n", getppid());
> > +#endif
> > fprintf(rpt, " at %s\n", show_date(time(NULL), 0, DATE_LOCAL));
> > fputc('\n', rpt);
> >
> > --
> > 1.5.6.1.255.g32571
>
> It does not matter too much for this part that writes crash report, but
> keeping the file format the same across platforms will make it easier for
> tools to read output, so as a general principle, I think this is a
> suboptimal solution to the issue. How about throwing something like this
> in MinGW specific header files?
>
> #define getppid() 0Of course, we could also implement it, using NtQueryInformationProcess() as suggested by Google.
Ciao, Dscho