git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] git-add--interactive: manual hunk editing mode

From
Jeff King <peff@peff.net>
Date
Jul 2, 2008, 08:32 UTC
Message-ID
<20080702083214.GA22301@sigill.intra.peff.net>
In-Reply-To
<7vd4lwemja.fsf@gitster.siamese.dyndns.org>
On Wed, Jul 02, 2008 at 01:08:09AM -0700, Junio C Hamano wrote:
Show 5 quoted lines
> > So if the problem is "old perl", I don't think it is an issue. Are there
> > modern perl installations in the wild that don't have File::Temp?
> 
> The thing is, I think I heard quite similar explanation why Test::More is
> safe to use when the patch to add t/t9700 was submit.  Then what happened?

ISTR the Test::More problem was reported by Linus, who is a Fedora user? I tried searching for any reasonable information on which of the core perl modules are installed by default on Fedora systems, but didn't come up with anything useful.

I really have no clue as to what is out there, and I suspect we must either play it totally safe, or push the limits and wait for people to complain about breakage.

-Peff
Previous: Junio C HamanoNext: Johannes Schindelin
Message 275 of 368 in “What's cooking in git.git (topics)”
  1. Junio C HamanoMar 9, 2008
  2. Junio C HamanoMar 12, 2008
  3. Johannes SchindelinMar 12, 2008
  4. Junio C HamanoMar 14, 2008
  5. Junio C HamanoMar 23, 2008
  6. Samuel TardieuMar 23, 2008
  7. Junio C HamanoMar 23, 2008
  8. Samuel TardieuMar 23, 2008
  9. Steffen ProhaskaMar 23, 2008
  10. Junio C HamanoMar 23, 2008
  11. Govind SalinasMar 23, 2008
  12. Junio C HamanoMar 24, 2008
  13. Junio C HamanoMar 28, 2008
  14. Junio C HamanoMar 31, 2008
  15. Junio C HamanoApr 4, 2008
  16. Kristian HøgsbergApr 4, 2008
  17. Junio C HamanoApr 4, 2008
  18. Johannes SchindelinApr 5, 2008
  19. Junio C HamanoApr 5, 2008
  20. Junio C HamanoApr 9, 2008
  21. Junio C HamanoApr 14, 2008
  22. Jeff KingApr 15, 2008
  23. Junio C HamanoApr 19, 2008
  24. Johannes SchindelinApr 19, 2008
  25. Lars HjemliApr 19, 2008
  26. Junio C HamanoApr 20, 2008
  27. Brandon CaseyApr 21, 2008
  28. Junio C HamanoApr 22, 2008
  29. Ping YinApr 22, 2008
  30. Josef WeidendorferApr 22, 2008
  31. Ping YinApr 22, 2008
  32. Johannes SchindelinApr 22, 2008
  33. Ping YinApr 23, 2008
  34. Ping YinApr 23, 2008
  35. Josef WeidendorferApr 22, 2008
  36. Ping YinApr 23, 2008
  37. Fedor SergeevApr 23, 2008
  38. Ping YinApr 23, 2008
  39. Robin RosenbergApr 23, 2008
  40. Fedor SergeevApr 23, 2008
  41. Michele BallabioApr 22, 2008
  42. Junio C HamanoApr 23, 2008
  43. Michele BallabioApr 23, 2008
  44. Junio C HamanoApr 27, 2008
  45. Ping YinApr 27, 2008
  46. Junio C HamanoMay 6, 2008
  47. Junio C HamanoMay 12, 2008
  48. Junio C HamanoMay 13, 2008
  49. Junio C HamanoMay 14, 2008
  50. Daniel BarkalowMay 14, 2008
  51. Junio C HamanoMay 15, 2008
  52. Steffen ProhaskaMay 15, 2008
  53. Junio C HamanoMay 22, 2008
  54. Johannes SchindelinMay 22, 2008
  55. Junio C HamanoMay 22, 2008
  56. Daniel BarkalowMay 22, 2008
  57. Stephan BeyerMay 25, 2008
  58. Junio C HamanoMay 26, 2008
  59. git-diff: allow --no-index semantics a bit moreJunio C Hamano, May 27, 2008
  60. Junio C HamanoMay 30, 2008
  61. Jon LoeligerMay 30, 2008
  62. Stephan BeyerMay 31, 2008
  63. Steven GrimmMay 30, 2008
  64. Junio C HamanoJun 2, 2008
  65. Jakub NarebskiJun 2, 2008
  66. Sebastian BoberJun 2, 2008
  67. Johannes SchindelinJun 2, 2008
  68. Shawn O. PearceJun 2, 2008
  69. Johannes SchindelinJun 2, 2008
  70. Junio C HamanoJun 2, 2008
  71. Johannes SchindelinJun 2, 2008
  72. Johannes SchindelinJun 2, 2008
  73. Junio C HamanoJun 13, 2008
  74. Junio C HamanoJun 18, 2008
  75. Johan HerlandJun 19, 2008
  76. Junio C HamanoJun 21, 2008
  77. Miklos VajnaJun 21, 2008
  78. Junio C HamanoJun 24, 2008
  79. Pieter de BieJun 24, 2008
  80. Pieter de BieJun 24, 2008
  81. Miklos VajnaJun 24, 2008
  82. Johannes SchindelinJun 24, 2008
  83. Miklos VajnaJun 24, 2008
  84. Johannes SchindelinJun 24, 2008
  85. Jakub NarebskiJun 24, 2008
  86. Johannes SchindelinJun 24, 2008
  87. Jakub NarebskiJun 24, 2008
  88. Jakub NarebskiJun 26, 2008
  89. Junio C HamanoJun 24, 2008
  90. Miklos VajnaJun 24, 2008
  91. Junio C HamanoJun 24, 2008
  92. Miklos VajnaJun 24, 2008
  93. Junio C HamanoJun 25, 2008
  94. しらいしななこJun 25, 2008
  95. Keep some git-* programs in $(bindir)Junio C Hamano, Jun 25, 2008
  96. Ask for "git program" when asking for "git-program" over SSH connectionJunio C Hamano, Jun 25, 2008
  97. Shawn O. PearceJun 25, 2008
  98. Junio C HamanoJun 25, 2008
  99. Shawn O. PearceJun 25, 2008
  100. Junio C HamanoJun 25, 2008
  101. Junio C HamanoJun 25, 2008
  102. Junio C HamanoJun 25, 2008
  103. Shawn O. PearceJun 25, 2008
  104. daemon: accept "git program" as wellJunio C Hamano, Jun 25, 2008
  105. Make clients ask for "git program" over ssh and local transportJunio C Hamano, Jun 25, 2008
  106. Ask for "git program" even against git-daemonJunio C Hamano, Jun 25, 2008
  107. Shawn O. PearceJun 25, 2008
  108. Junio C HamanoJun 25, 2008
  109. Shawn O. PearceJun 25, 2008
  110. Junio C HamanoJun 26, 2008
  111. Shawn O. PearceJun 25, 2008
  112. Shawn O. PearceJun 25, 2008
  113. Junio C HamanoJun 25, 2008
  114. Tommi VirtanenJun 26, 2008
  115. Olivier MarinJun 26, 2008
  116. Junio C HamanoJun 26, 2008
  117. Theodore TsoJun 25, 2008
  118. Junio C HamanoJun 25, 2008
  119. Shawn O. PearceJun 25, 2008
  120. Junio C HamanoJun 25, 2008
  121. Junio C HamanoJun 25, 2008
  122. Shawn O. PearceJun 25, 2008
  123. Daniel BarkalowJun 25, 2008
  124. Shawn O. PearceJun 25, 2008
  125. Shawn O. PearceJun 25, 2008
  126. Jakub NarebskiJun 25, 2008
  127. Shawn O. PearceJun 25, 2008
  128. Miklos VajnaJun 25, 2008
  129. Junio C HamanoJun 23, 2008
  130. Miklos VajnaJun 23, 2008
  131. Junio C HamanoJun 25, 2008
  132. Make default expiration period of reflog used for stash infiniteJunio C Hamano, Jun 29, 2008
  133. Olivier MarinJun 30, 2008
  134. Junio C HamanoJul 1, 2008
  135. Disconnect stash from its base commitNanako Shiraishi, Jul 2, 2008
  136. Johannes SchindelinJul 2, 2008
  137. Junio C HamanoJul 2, 2008
  138. Abhijit Menon-SenJul 2, 2008
  139. Junio C HamanoJul 2, 2008
  140. Implement "git stash branch <newbranch> <stash>"Abhijit Menon-Sen, Jul 3, 2008
  141. Junio C HamanoJul 3, 2008
  142. Implement "git stash branch <newbranch> <stash>"Abhijit Menon-Sen, Jul 3, 2008
  143. Implement "git stash branch <newbranch> <stash>"Abhijit Menon-Sen, Jul 6, 2008
  144. Johannes SchindelinJul 6, 2008
  145. Add a test for "git stash branch"Abhijit Menon-Sen, Jul 6, 2008
  146. Junio C HamanoJul 6, 2008
  147. Add a test for "git stash branch"Abhijit Menon-Sen, Jul 6, 2008
  148. Teach git-merge to pass -X<option> to the backend strategy moduleJunio C Hamano, Jun 29, 2008
  149. Jakub NarebskiJun 29, 2008
  150. Junio C HamanoJun 29, 2008
  151. Junio C HamanoJun 29, 2008
  152. Linus TorvaldsJun 29, 2008
  153. Junio C HamanoJun 29, 2008
  154. Junio C HamanoJun 29, 2008
  155. Pieter de BieJun 29, 2008
  156. Johannes SchindelinJun 29, 2008
  157. Steffen ProhaskaJun 29, 2008
  158. Jeff KingJun 30, 2008
  159. Junio C HamanoJun 30, 2008
  160. Jeff KingJun 30, 2008
  161. Junio C HamanoJun 30, 2008
  162. Junio C HamanoJun 30, 2008
  163. How to reduce remaining differences to 4msysgit? (was What's cooking in git.git (topics))Steffen Prohaska, Jun 30, 2008
  164. Johannes SixtJun 30, 2008
  165. Clifford CaoileJul 1, 2008
  166. Steffen ProhaskaJul 2, 2008
  167. 01/12 Fake reencoding success under NO_ICONV instead of returning NULL.Steffen Prohaska, Jul 2, 2008
  168. 02/12 Do not complain about "no common commits" in an empty repoSteffen Prohaska, Jul 2, 2008
  169. 03/12 MinGW: Convert CR/LF to LF in tag signaturesSteffen Prohaska, Jul 2, 2008
  170. 04/12 Avoid calling signal(SIGPIPE, ..) for MinGW builds.Steffen Prohaska, Jul 2, 2008
  171. 05/12 Windows(msysgit): Per default, display help as HTML in default browserSteffen Prohaska, Jul 2, 2008
  172. 06/12 connect: Fix custom ports with plink (Putty's ssh)Steffen Prohaska, Jul 2, 2008
  173. 07/12 Fixed text file auto-detection: treat EOF character 032 at the end of file as printableSteffen Prohaska, Jul 2, 2008
  174. 08/12 fast-import: MinGW does not have getppid(). So do not print it.Steffen Prohaska, Jul 2, 2008
  175. 09/12 We need to check for msys as well as Windows in add--interactive.Steffen Prohaska, Jul 2, 2008
  176. 10/12 Add ANSI control code emulation for the Windows consoleSteffen Prohaska, Jul 2, 2008
  177. 11/12 verify_path(): do not allow absolute pathsSteffen Prohaska, Jul 2, 2008
  178. 12/12 [TODO] setup: bring changes from 4msysgit/next to nextSteffen Prohaska, Jul 2, 2008
  179. Johannes SchindelinJul 2, 2008
  180. Steffen ProhaskaJul 2, 2008
  181. Johannes SixtJul 2, 2008
  182. Steffen ProhaskaJul 3, 2008
  183. Junio C HamanoJul 3, 2008
  184. Junio C HamanoJul 2, 2008
  185. Steffen ProhaskaJul 2, 2008
  186. Johannes SchindelinJul 2, 2008
  187. Steffen ProhaskaJul 2, 2008
  188. Johannes SchindelinJul 2, 2008
  189. Johannes SixtJul 2, 2008
  190. Peter HarrisJul 2, 2008
  191. Johannes SixtJul 7, 2008
  192. Junio C HamanoJul 2, 2008
  193. Steffen ProhaskaJul 2, 2008
  194. Johannes SchindelinJul 2, 2008
  195. Junio C HamanoJul 2, 2008
  196. Fixed text file auto-detection: treat EOF character 032 at the end of file as printableSteffen Prohaska, Jul 11, 2008
  197. Johannes SchindelinJul 11, 2008
  198. Steffen ProhaskaJul 11, 2008
  199. Johannes SchindelinJul 11, 2008
  200. Johannes SixtJul 2, 2008
  201. Johannes SchindelinJul 3, 2008
  202. Steffen ProhaskaJul 4, 2008
  203. Junio C HamanoJul 4, 2008
  204. Steffen ProhaskaJul 4, 2008
  205. Clifford CaoileJul 4, 2008
  206. Edward Z. YangJul 4, 2008
  207. Junio C HamanoJul 2, 2008
  208. Johannes SixtJul 2, 2008
  209. Steffen ProhaskaJul 4, 2008
  210. 1/2 help.c: Add support for htmldir relative to git_exec_path()Steffen Prohaska, Jul 4, 2008
  211. 2/2 help (Windows): Display HTML in default browser using Win32 APISteffen Prohaska, Jul 4, 2008
  212. Junio C HamanoJul 4, 2008
  213. Johannes SchindelinJul 4, 2008
  214. Steffen ProhaskaJul 11, 2008
  215. 1/3 Move code interpreting path relative to exec-dir to new function system_path()Steffen Prohaska, Jul 11, 2008
  216. 2/3 help.c: Add support for htmldir relative to git_exec_path()Steffen Prohaska, Jul 11, 2008
  217. 3/3 help (Windows): Display HTML in default browser using Windows' shell APISteffen Prohaska, Jul 11, 2008
  218. Steffen ProhaskaJul 11, 2008
  219. 3/3 help (Windows): Display HTML in default browser using Windows' shell APISteffen Prohaska, Jul 11, 2008
  220. Junio C HamanoJul 12, 2008
  221. Steffen ProhaskaJul 12, 2008
  222. Junio C HamanoJul 12, 2008
  223. Johannes SixtJul 12, 2008
  224. Junio C HamanoJul 13, 2008
  225. Move code interpreting path relative to exec-dir to new function system_path()Johannes Sixt, Jul 13, 2008
  226. help.c: Add support for htmldir relative to git_exec_path()Johannes Sixt, Jul 13, 2008
  227. help (Windows): Display HTML in default browser using Windows' shell APIJohannes Sixt, Jul 13, 2008
  228. Fix relative built-in paths to be relative to the command invocationJohannes Sixt, Jul 13, 2008
  229. Allow the built-in exec path to be relative to the command invocation pathJohannes Sixt, Jul 13, 2008
  230. Allow add_path() to add non-existent directories to the pathJohannes Sixt, Jul 13, 2008
  231. Johannes SixtJul 14, 2008
  232. Johannes SchindelinJul 13, 2008
  233. Johannes SchindelinJul 13, 2008
  234. Johannes SixtJul 14, 2008
  235. Johannes SchindelinJul 14, 2008
  236. Johannes SixtJul 14, 2008
  237. Junio C HamanoJul 14, 2008
  238. Johannes SixtJul 14, 2008
  239. 0/5 replacement for the part of js/more-win that is in puJohannes Sixt, Jul 14, 2008
  240. 1/5 Makefile: Normalize $(bindir) and $(gitexecdir) before comparingJohannes Sixt, Jul 14, 2008
  241. 2/5 Record the command invocation path earlyJohannes Sixt, Jul 14, 2008
  242. 3/5 Fix relative built-in paths to be relative to the command invocationJohannes Sixt, Jul 14, 2008
  243. 4/5 Allow the built-in exec path to be relative to the command invocation pathJohannes Sixt, Jul 14, 2008
  244. 5/5 Allow add_path() to add non-existent directories to the pathJohannes Sixt, Jul 14, 2008
  245. Johannes SixtJul 15, 2008
  246. Johannes SixtJul 11, 2008
  247. Junio C HamanoJul 2, 2008
  248. Marius Storm-OlsenJul 2, 2008
  249. Steffen ProhaskaJul 2, 2008
  250. Johannes SixtJul 2, 2008
  251. Johannes SchindelinJul 3, 2008
  252. Convert CR/LF to LF in tag signaturesSteffen Prohaska, Jul 11, 2008
  253. Junio C HamanoJul 2, 2008
  254. Steffen ProhaskaJul 2, 2008
  255. Johannes SchindelinJul 2, 2008
  256. Johannes SixtJul 2, 2008
  257. Kristian HøgsbergJun 30, 2008
  258. Jakub NarebskiJun 30, 2008
  259. Junio C HamanoJun 30, 2008
  260. Junio C HamanoJun 30, 2008
  261. Andrew MortonJun 30, 2008
  262. Johannes SchindelinJun 30, 2008
  263. Petr BaudisJun 30, 2008
  264. Stephen RothwellJul 1, 2008
  265. Kristian HøgsbergJul 1, 2008
  266. Jeff KingJul 1, 2008
  267. git-add--interactive: manual hunk editing modeThomas Rast, Jul 1, 2008
  268. Johannes SchindelinJul 1, 2008
  269. Junio C HamanoJul 1, 2008
  270. Junio C HamanoJul 2, 2008
  271. Thomas RastJul 2, 2008
  272. Junio C HamanoJul 2, 2008
  273. Jeff KingJul 2, 2008
  274. Junio C HamanoJul 2, 2008
  275. Jeff KingJul 2, 2008
  276. Johannes SchindelinJul 2, 2008
  277. Junio C HamanoJul 2, 2008
  278. 0/3 git-add--interactive: use --recount, editingThomas Rast, Jul 2, 2008
  279. 1/3 git-add--interactive: replace hunk recounting with apply --recountThomas Rast, Jul 2, 2008
  280. 2/3 git-add--interactive: remove hunk coalescingThomas Rast, Jul 2, 2008
  281. 3/3 git-add--interactive: manual hunk editing modeThomas Rast, Jul 2, 2008
  282. Junio C HamanoJul 2, 2008
  283. Junio C HamanoJul 2, 2008
  284. Thomas RastJul 3, 2008
  285. Junio C HamanoJul 3, 2008
  286. Junio C HamanoJul 2, 2008
  287. Junio C HamanoJul 6, 2008
  288. Johannes SchindelinJul 6, 2008
  289. Junio C HamanoJul 7, 2008
  290. Junio C HamanoJul 8, 2008
  291. Junio C HamanoJul 10, 2008
  292. Junio C HamanoJul 14, 2008
  293. Junio C HamanoJul 14, 2008
  294. Closing the merge window for 1.6.0Junio C Hamano, Jul 14, 2008
  295. Johannes SixtJul 14, 2008
  296. Jakub NarebskiJul 14, 2008
  297. Petr BaudisJul 14, 2008
  298. Johannes SchindelinJul 14, 2008
  299. Gerrit PapeJul 14, 2008
  300. Johannes SchindelinJul 14, 2008
  301. Nicolas PitreJul 14, 2008
  302. Junio C HamanoJul 14, 2008
  303. Teemu LikonenJul 14, 2008
  304. Martin LanghoffJul 15, 2008
  305. Petr BaudisJul 15, 2008
  306. Dmitry PotapovJul 15, 2008
  307. Johannes SchindelinJul 15, 2008
  308. Avery PennarunJul 15, 2008
  309. Nicolas PitreJul 15, 2008
  310. Sverre RabbelierJul 15, 2008
  311. Petr BaudisJul 15, 2008
  312. Dmitry PotapovJul 15, 2008
  313. Junio C HamanoJul 15, 2008
  314. Johannes SchindelinJul 15, 2008
  315. Junio C HamanoJul 15, 2008
  316. Johannes SchindelinJul 15, 2008
  317. Shawn O. PearceJul 15, 2008
  318. Nicolas PitreJul 15, 2008
  319. Petr BaudisJul 14, 2008
  320. Nick AndrewJul 20, 2008
  321. Junio C HamanoJul 14, 2008
  322. Petr BaudisJul 15, 2008
  323. Johannes SchindelinJul 14, 2008
  324. Lea WiemannJul 14, 2008
  325. Lea WiemannJul 14, 2008
  326. Junio C HamanoJul 15, 2008
  327. Geoffrey IrvingJul 15, 2008
  328. Johannes SchindelinJul 15, 2008
  329. Geoffrey IrvingJul 15, 2008
  330. Junio C HamanoJul 16, 2008
  331. Junio C HamanoJul 17, 2008
  332. Stephan BeyerJul 17, 2008
  333. Nanako ShiraishiJul 18, 2008
  334. Junio C HamanoJul 18, 2008
  335. Nanako ShiraishiJul 18, 2008
  336. Junio C HamanoJul 18, 2008
  337. Johannes SchindelinJul 18, 2008
  338. Junio C HamanoJul 19, 2008
  339. Johannes SchindelinJul 19, 2008
  340. Junio C HamanoJul 19, 2008
  341. Johannes SchindelinJul 19, 2008
  342. Miklos VajnaJul 20, 2008
  343. Johannes SchindelinJul 20, 2008
  344. Junio C HamanoJul 20, 2008
  345. Johannes SchindelinJul 20, 2008
  346. Junio C HamanoJul 20, 2008
  347. Sverre RabbelierJul 20, 2008
  348. Miklos VajnaJul 20, 2008
  349. Sverre RabbelierJul 20, 2008
  350. Jakub NarebskiJul 21, 2008
  351. Junio C HamanoJul 20, 2008
  352. Johannes SchindelinJul 20, 2008
  353. Petr BaudisJul 18, 2008
  354. Junio C HamanoJul 18, 2008
  355. Nanako ShiraishiJul 19, 2008
  356. Yaroslav HalchenkoDec 13, 2010
  357. Junio C HamanoDec 13, 2010
  358. Yaroslav HalchenkoDec 13, 2010
  359. Junio C HamanoDec 13, 2010
  360. Yaroslav HalchenkoDec 13, 2010
  361. Johannes SixtDec 14, 2010
  362. Yaroslav HalchenkoDec 14, 2010
  363. Johannes SchindelinJul 18, 2008
  364. Nanako ShiraishiJul 20, 2008
  365. Junio C HamanoJul 20, 2008
  366. Petr BaudisJul 20, 2008
  367. Junio C HamanoJul 20, 2008
  368. Brandon CaseyJun 30, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.