Re: [PATCH] Fix relative built-in paths to be relative to the command invocation
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Jul 14, 2008, 12:20 UTC
- Message-ID
- <alpine.DEB.1.00.0807141319420.8950@racer>
- In-Reply-To
- <1216018557.487af87d7bd28@webmail.eunet.at>
Hi,
On Mon, 14 Jul 2008, Johannes Sixt wrote:
Show 21 quoted lines
> Zitat von Johannes Schindelin <Johannes.Schindelin@gmx.de>: > > > On Sun, 13 Jul 2008, Johannes Sixt wrote: > > > > > @@ -84,7 +90,7 @@ static void add_path(struct strbuf *out, const char > > > *path) > > > } > > > } > > > > > > -void setup_path(const char *cmd_path) > > > +void setup_path(void) > > > > It seems to me that this patch would not do anything different, but > > with less code change, if setup_path() would set argv0_path, and not a > > new function was introduced. > > This is just to play a safe game. I had it that way, but I decided to have > the call to the new git_set_argv0_path() early in git.c because the call > to setup_path() in git.c is very late, and it could happen that we call > system_path() (which needs argv0_path) before that. Although I didn't audit > the code whether this really happens.
Well, okay... I would have rather seen it not change (since there was no bug to fix), or as a separate patch, but it's Junio's call.
Ciao, Dscho