Re: [PATCH v3 00/20] Let Git's tests pass on Windows

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Jan 28, 2016, 08:57 UTC
Message-ID: <alpine.DEB.2.20.1601280957040.2964@virtualbox>
In-Reply-To: <CAPig+cQR11JtTrcHNAWytTRfdWis4qmzODs-Key-8c+8fgKoUQ@mail.gmail.com>

Hi Eric,

On Thu, 28 Jan 2016, Eric Sunshine wrote:

Show 14 quoted lines

> On Wed, Jan 27, 2016 at 11:19 AM, Johannes Schindelin
> <johannes.schindelin@gmx.de> wrote:
> > Relative to v2, this fixes stupid typos that made the tests fail on
> > Linux, a stupid copy-paste error pointed out by Eric Sunshine,
> > unnecessary 'printf ""' calls pointed out by Junio Hamano, and I now
> > use `test_have_prereq !MINGW` consistently, as pointed out by both Eric
> > and Junio. This time, I also send the patch series with the character
> > set set (sic!) to UTF-8. Oh, and this time, I also made sure that the
> > regression tests pass on Windows & Linux alike.
> 
> For what it's worth, I ran the test suite on Mac OS X and FreeBSD, as
> well, with this series applied and didn't run across any problems. I
> also read through v3 and, other than the micro nit in patch 11/20,
> didn't find anything upon which to comment.

Thank you so much! I really appreciate your feedback, and I have a lot of respect for reviewers that go through a 19 or 20 strong patch series.

Thanks! Dscho