Re: [PATCH 12/19] mingw: do not use symlinks with SVN in t9100

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Jan 25, 2016, 16:53 UTC
Message-ID: <alpine.DEB.2.20.1601251752450.2964@virtualbox>
In-Reply-To: <xmqqegd6bf4j.fsf@gitster.mtv.corp.google.com>

Hi Junio,

On Sun, 24 Jan 2016, Junio C Hamano wrote:

Show 18 quoted lines

> Johannes Schindelin <johannes.schindelin@gmx.de> writes:
> 
> > From: Karsten Blees <blees@dcon.de>
> >
> > The SVN library does not seem to support symlinks, even if symlinks are
> > enabled in MSYS2 and Git. Use 'cp' instead of 'ln -s'.
> >
> > This partially fixes t/t9100-git-svn-basic.sh
> >
> > Signed-off-by: Karsten Blees <blees@dcon.de>
> > Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
> > ---
> >  t/t9100-git-svn-basic.sh | 9 ++++++++-
> >  1 file changed, 8 insertions(+), 1 deletion(-)
> 
> For the purpose of SVN test, is it important that foo.link is a link
> to foo?  I am wondering what would be the fallout from making this
> change without "only on MINGW do this".

(I originally sent the following response as a reply to 13/19 by mistake.)

Your comment made me inspect the entire t9100 again, wondering why things work when we copy the contents instead of symlinking them. And you know what, even if I could have sworn that I verified for every patch in this series that it is actually necessary to pass the test suite, it is *not* necessary.

So I backed it out and it won't be part of v2 anymore.

Ciao, Dscho