Re: [PATCH 16/19] mingw: avoid absolute path in t0008

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Jan 25, 2016, 16:48 UTC
Message-ID: <alpine.DEB.2.20.1601251747050.2964@virtualbox>
In-Reply-To: <xmqq60yibe89.fsf@gitster.mtv.corp.google.com>

Hi Junio,

On Sun, 24 Jan 2016, Junio C Hamano wrote:

Show 15 quoted lines

> Johannes Schindelin <johannes.schindelin@gmx.de> writes:
> 
> > From: Pat Thoyts <patthoyts@users.sourceforge.net>
> >
> > The test separator char is a colon which means any absolute paths on
> > Windows confuse the tests that use global_excludes.
> >
> > Suggested-by: Karsten Blees <karsten.blees@gmail.com>
> > Signed-off-by: Pat Thoyts <patthoyts@users.sourceforge.net>
> > Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
> > ---
> >  t/t0008-ignores.sh | 8 +++++++-
> 
> Is the fact that $global_excludes is specified using an absolute
> path significant to the correctness of this test script?

Apparently not. So I followed your suggestion and made this independent of the OS:

	https://github.com/dscho/git/commit/0b9eb308

Show 6 quoted lines

> A larger question is if it would make more sense for Git ported to
> Windows environment to use semicolon (that is the element separator
> for %PATH% in the Windows land, right?) instead where POSIXy port
> would use colon as the separator.  A variable that is a list of
> locations (e.g. $PATH) makes little sense when elements can only be
> relative paths in practice.

Oh my... I was not looking for more work ;-)

Seriously again, I do agree with the suggestion to use semicolons on Windows as path lists' separators instead of colons.

Ciao, Dscho