Re: [PATCH 06/19] mingw: try to delete target directory before renaming

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Jan 26, 2016, 08:14 UTC
Message-ID: <alpine.DEB.2.20.1601260900550.2964@virtualbox>
In-Reply-To: <xmqq4me1h4k2.fsf@gitster.mtv.corp.google.com>

Hi Junio,

On Mon, 25 Jan 2016, Junio C Hamano wrote:

Show 20 quoted lines

> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> 
> > On Sun, 24 Jan 2016, Philip Oakley wrote:
> >
> >> From: "Johannes Schindelin" <johannes.schindelin@gmx.de>
> >> >From: 마누엘 <nalla@users.noreply.github.com>
> >> 
> >> Is this Nalla's preferred email, or just a carry over from cautions
> >> of the Github interface?
> >
> > Neither. It is from the author field as recorded in the commit that I
> > merged originally: https://github.com/dscho/git/pull/8
> 
> If it is not recorded under the name/email that is preferred by the
> author, as I am not pulling from you but will be applying a patch,
> we can fix it to match the author's desire, if we wanted to.
> 
> Your "Neither" hints that it is the case, but it is unclear to me
> what address is the desired one (I can guess hamal.uberspace might
> be), so...

The author clarified to me that the noreply "address" was used only in the early patches, but the uberspace one is the preferred one.

I fixed it in my branch; v2 will have the fix.

Ciao, Dscho