Re: [PATCH v3 11/20] tests: turn off git-daemon tests if FIFOs are not available
- From
Eric Sunshine <sunshine@sunshineco.com>
- Date
- Jan 28, 2016, 08:21 UTC
- Message-ID
- <CAPig+cRXV-nv1ZZv1MrujdF3YfZMgwusTcBHAXnyCRaYyXmRWg@mail.gmail.com>
- In-Reply-To
- <35b05b7e0d01bf550b698d3c6ecc577eb80d4149.1453911367.git.johannes.schindelin@gmx.de>
On Wed, Jan 27, 2016 at 11:19 AM, Johannes Schindelin <johannes.schindelin@gmx.de> wrote:
Show 17 quoted lines
> The Git daemon tests create a FIFO first thing and will hang if said > FIFO is not available. > > This is a problem with Git for Windows, where `mkfifo` is an MSYS2 > program that leverages MSYS2's POSIX emulation layer, but > `git-daemon.exe` is a MINGW program that has not the first clue about > that POSIX emulation layer and therefore blinks twice when it sees > MSYS2's emulated FIFOs and then just stares into space. > > This lets t5570-git-daemon.sh and t5811-proto-disable-git.sh pass. > > Signed-off-by: Stepan Kasal <kasal@ucw.cz> > Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de> > --- > diff --git a/t/lib-git-daemon.sh b/t/lib-git-daemon.sh > @@ -23,6 +23,11 @@ then > +if ! test_have_prereq PIPE
Maybe:
if test_have_prereq !PIPE
?
Show 9 quoted lines
> +then
> + test_skip_or_die $GIT_TEST_GIT_DAEMON "file system does not support FIFOs"
> +fi
> +
> LIB_GIT_DAEMON_PORT=${LIB_GIT_DAEMON_PORT-${this_test#t}}
>
> GIT_DAEMON_PID=
> --
> 2.7.0.windows.1.7.g55a05c8