Re: [PATCH v2 19/19] mingw: do not bother to test funny file names

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Jan 26, 2016, 20:03 UTC
Message-ID: <CAPig+cQXVwfyaEzf9fR2tFNon-Jq93iPCMwW9gsB8BnUVv5p3A@mail.gmail.com>
In-Reply-To: <47914e4ceb3ea51636dd5ae308679c9c92fcbef0.1453818790.git.johannes.schindelin@gmx.de>

On Tue, Jan 26, 2016 at 9:35 AM, Johannes Schindelin <johannes.schindelin@gmx.de> wrote:

Show 13 quoted lines

> MSYS2 actually allows to create files or directories whose names contain
> tabs, newlines or colors, even if plain Win32 API cannot access them.
> As we are using an MSYS2 bash to run the tests, such files or
> directories are created successfully, but Git itself has no chance to
> work with them because it is a regular Windows program, hence limited by
> the Win32 API.
> [...]
> Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
> ---
> diff --git a/t/t3600-rm.sh b/t/t3600-rm.sh
> @@ -14,7 +14,8 @@ test_expect_success \
> -if touch -- 'tab       embedded' 'newline
> +

Is this new blank line intentional?

> +if ! test_have_prereq MINGW && touch -- 'tab   embedded' 'newline
> [...]
> +test_have_prereq !MINGW &&

Where negation is concerned, is there a non-obvious reason that this patch sometimes says:

    ! test_have_prereq MINGW

and sometimes:

    test_have_prereq !MINGW

? Is one form preferred over the other?