Re: [PATCH v3 00/20] Let Git's tests pass on Windows

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Jan 28, 2016, 08:42 UTC
Message-ID: <CAPig+cQR11JtTrcHNAWytTRfdWis4qmzODs-Key-8c+8fgKoUQ@mail.gmail.com>
In-Reply-To: <cover.1453911367.git.johannes.schindelin@gmx.de>

On Wed, Jan 27, 2016 at 11:19 AM, Johannes Schindelin <johannes.schindelin@gmx.de> wrote:

Show 7 quoted lines

> Relative to v2, this fixes stupid typos that made the tests fail on
> Linux, a stupid copy-paste error pointed out by Eric Sunshine,
> unnecessary 'printf ""' calls pointed out by Junio Hamano, and I now
> use `test_have_prereq !MINGW` consistently, as pointed out by both Eric
> and Junio. This time, I also send the patch series with the character
> set set (sic!) to UTF-8. Oh, and this time, I also made sure that the
> regression tests pass on Windows & Linux alike.

For what it's worth, I ran the test suite on Mac OS X and FreeBSD, as well, with this series applied and didn't run across any problems. I also read through v3 and, other than the micro nit in patch 11/20, didn't find anything upon which to comment.