Re: [PATCH 01/19] mingw: let's use gettext with MSYS2

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Jan 25, 2016, 16:16 UTC
Message-ID: <alpine.DEB.2.20.1601251714380.2964@virtualbox>
In-Reply-To: <xmqqio2ibfkn.fsf@gitster.mtv.corp.google.com>

Hi Junio,

On Sun, 24 Jan 2016, Junio C Hamano wrote:

Show 11 quoted lines

> Johannes Schindelin <johannes.schindelin@gmx.de> writes:
> 
> > This solves two problems:
> >
> > - we now have proper localisation even on Windows
> >
> > - we sidestep the infamous "BUG: your vsnprintf is broken (returned -1)"
> >   message when running "git init" (which otherwise prevents the entire
> >   test suite from running)
> 
> It is unclear to me how gettext is related to use of vsnprintf().

Including libintl.h overrides vsnprintf() with the libintl_vsnprintf() drop-in replacement that does return the expected value.

I updated the commit message (will be part of v2):

	https://github.com/dscho/git/commit/4473801e

Ciao, Dscho