Re: [PATCH v3 11/20] tests: turn off git-daemon tests if FIFOs are not available
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Jan 28, 2016, 08:40 UTC
- Message-ID
- <alpine.DEB.2.20.1601280939170.2964@virtualbox>
- In-Reply-To
- <CAPig+cRXV-nv1ZZv1MrujdF3YfZMgwusTcBHAXnyCRaYyXmRWg@mail.gmail.com>
Hi Eric,
On Thu, 28 Jan 2016, Eric Sunshine wrote:
Show 25 quoted lines
> On Wed, Jan 27, 2016 at 11:19 AM, Johannes Schindelin > <johannes.schindelin@gmx.de> wrote: > > The Git daemon tests create a FIFO first thing and will hang if said > > FIFO is not available. > > > > This is a problem with Git for Windows, where `mkfifo` is an MSYS2 > > program that leverages MSYS2's POSIX emulation layer, but > > `git-daemon.exe` is a MINGW program that has not the first clue about > > that POSIX emulation layer and therefore blinks twice when it sees > > MSYS2's emulated FIFOs and then just stares into space. > > > > This lets t5570-git-daemon.sh and t5811-proto-disable-git.sh pass. > > > > Signed-off-by: Stepan Kasal <kasal@ucw.cz> > > Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de> > > --- > > diff --git a/t/lib-git-daemon.sh b/t/lib-git-daemon.sh > > @@ -23,6 +23,11 @@ then > > +if ! test_have_prereq PIPE > > Maybe: > > if test_have_prereq !PIPE > > ?
Darn. Of course I only looked for '! .*MINGW', but I should have looked for '! test_have_prereq' in the patches.
Junio, could you kindly fix up locally if this is the only remaining issue of this patch series?
Thanks, Dscho