Re: [PATCH v2 19/19] mingw: do not bother to test funny file names

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Jan 27, 2016, 08:33 UTC
Message-ID: <alpine.DEB.2.20.1601270859470.2964@virtualbox>
In-Reply-To: <CAPig+cQXVwfyaEzf9fR2tFNon-Jq93iPCMwW9gsB8BnUVv5p3A@mail.gmail.com>

Hi Eric,

On Tue, 26 Jan 2016, Eric Sunshine wrote:

Show 17 quoted lines

> On Tue, Jan 26, 2016 at 9:35 AM, Johannes Schindelin
> <johannes.schindelin@gmx.de> wrote:
> > MSYS2 actually allows to create files or directories whose names contain
> > tabs, newlines or colors, even if plain Win32 API cannot access them.
> > As we are using an MSYS2 bash to run the tests, such files or
> > directories are created successfully, but Git itself has no chance to
> > work with them because it is a regular Windows program, hence limited by
> > the Win32 API.
> > [...]
> > Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
> > ---
> > diff --git a/t/t3600-rm.sh b/t/t3600-rm.sh
> > @@ -14,7 +14,8 @@ test_expect_success \
> > -if touch -- 'tab       embedded' 'newline
> > +
> 
> Is this new blank line intentional?

Absolutely not! ;-) Fixed.

Show 14 quoted lines

> > +if ! test_have_prereq MINGW && touch -- 'tab   embedded' 'newline
> > [...]
> > +test_have_prereq !MINGW &&
> 
> Where negation is concerned, is there a non-obvious reason that this
> patch sometimes says:
> 
>     ! test_have_prereq MINGW
> 
> and sometimes:
> 
>     test_have_prereq !MINGW
> 
> ? Is one form preferred over the other?

Hysterical raisins. I changed all of them to the latter form, as suggested by Junio.

Ciao, Dscho