Re: [ANNOUNCE] Example Cogito Addon - cogito-bundle
- From
Nicolas Pitre <nico@cam.org>
- Date
- Oct 19, 2006, 14:27 UTC
- Message-ID
- <Pine.LNX.4.64.0610191025340.1971@xanadu.home>
- In-Reply-To
- <7vac3tx900.fsf@assigned-by-dhcp.cox.net>
On Wed, 18 Oct 2006, Junio C Hamano wrote:
Show 12 quoted lines
> Linus Torvalds <torvalds@osdl.org> writes: > > > Actually, I've hit an impasse. > > > > So there's _another_ way of fixing a thin pack: it's to expand the objects > > without a base into non-delta objects, and keeping the number of objects > > in the pack the same. But _again_, we don't actually know which ones to > > expand until it's too late. > > pack-objects.c::write_one() makes sure that we write out base > immediately after delta if we haven't written out its base yet, > so I suspect if you buffer one delta you should be Ok, no?
If we create full packs out of thin packs the base objects will end up at the end of the pack so this assumption is a bad one to rely upon if we want to make things robust (like being able to feed such a pack back).
Nicolas