Re: PPC SHA-1 Updates in "pu"

From: Linus Torvalds <torvalds@osdl.org>
Date: Jun 24, 2006, 20:42 UTC
Message-ID: <Pine.LNX.4.64.0606241338370.6483@g5.osdl.org>
In-Reply-To: <7vhd2atid1.fsf@assigned-by-dhcp.cox.net>

On Sat, 24 Jun 2006, Junio C Hamano wrote:

Show 6 quoted lines

> Linus Torvalds <torvalds@osdl.org> writes:
> 
> > Also, "pu" in general is totally unusable. It doesn't even compile.
> 
> Care to share problems with Pasky and I to take a look at,
> please?

Don't everybody see them?

	In file included from Git.xs:8:
	../cache.h:6:10: error: #include expects "FILENAME" or <FILENAME>
	In file included from /usr/lib/perl5/5.8.8/ppc-linux-thread-multi/CORE/perl.h:756,
	                 from Git.xs:15:
	/usr/lib/perl5/5.8.8/ppc-linux-thread-multi/CORE/embed.h:4195:1: warning: "die" redefined
	Git.xs:11:1: warning: this is the location of the previous definition
	Git.xs: In function 'boot_Git':
	Git.xs:57: warning: passing argument 1 of 'set_error_routine' from incompatible pointer type
	Git.xs:58: warning: passing argument 1 of 'set_die_routine' makes qualified function pointer from unqualified
	make[1]: *** [Git.o] Error 1
	make[1]: Leaving directory `/home/torvalds/git/perl'
	make: *** [all] Error 2

how does that compile for anybody else, when -DSHA1_HEADER isn't set correctly? The quotes have gone missing:

	-DSHA1_HEADER='ppc/sha1.h'

don't ask me why.

		Linus