Re: [PATCH] Git.pm build: Fix quoting and missing GIT-CFLAGS dependency

From: Junio C Hamano <junkio@cox.net>
Date: Jun 26, 2006, 06:48 UTC
Message-ID: <7vk674mmyo.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <20060625152157.GG21864@pasky.or.cz>

Petr Baudis <pasky@suse.cz> writes:

> Could you please also throw in these two?
>
> [PATCH 3/7] Git.pm: Swap hash_object() parameters
> [PATCH 4/7] Git.pm: Fix Git->repository("/somewhere/totally/elsewhere")

Will take a look.

Show 7 quoted lines

> Yes, -I is very broken. I have abandoned it in:
>
> 	Subject: Re: [PATCH 01/12] Introduce Git.pm (v4)
> 	Date:   Sat, 24 Jun 2006 13:52:27 +0200
>
> The advantage to your approach is that it works properly without
> requiring to make install even outside of the testsuite.

I remember myself getting utterly discusted when I saw the inclusion of the build-time blib directory in the search path in some other Perl code outside git.

Worse yet, I suspect the order you do the two directories is wrong to prefer the freshly built one over the one you installed the last time, but I was trying not to stare at too much for health reasons so ... ;-).