git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] Git.pm build: Fix quoting and missing GIT-CFLAGS dependency

From
Petr Baudis <pasky@suse.cz>
Date
Jun 25, 2006, 01:40 UTC
Message-ID
<20060625014009.GA21864@pasky.or.cz>
In-Reply-To
<20060625010202.GX21864@pasky.or.cz>
Signed-off-by: Petr Baudis <pasky@suse.cz>
---
  This one should do a better job; if we quote, let's do it proper. :-)
 Makefile |   12 ++++++++----
 1 files changed, 8 insertions(+), 4 deletions(-)
diff --git a/Makefile b/Makefile
index 9a59466..fb9ffad 100644
--- a/Makefile
+++ b/Makefile
@@ -608,11 +608,15 @@ XDIFF_OBJS=xdiff/xdiffi.o xdiff/xprepare
 	rm -f $@ && $(AR) rcs $@ $(XDIFF_OBJS)
 
 
-perl/Makefile:	perl/Git.pm perl/Makefile.PL
+PERL_DEFINE = $(ALL_CFLAGS) -DGIT_VERSION='"$(GIT_VERSION)"'
+PERL_DEFINE_SQ = $(subst ','\'',$(PERL_DEFINE))
+PERL_LIBS = $(EXTLIBS)
+PERL_LIBS_SQ = $(subst ','\'',$(PERL_LIBS))
+perl/Makefile:	perl/Git.pm perl/Makefile.PL GIT-CFLAGS
 	(cd perl && $(PERL_PATH) Makefile.PL \
-		PREFIX="$(prefix)" \
-		DEFINE="$(ALL_CFLAGS) -DGIT_VERSION=\\\"$(GIT_VERSION)\\\"" \
-		LIBS="$(EXTLIBS)")
+		PREFIX='$(prefix_SQ)' \
+		DEFINE='$(PERL_DEFINE_SQ)' \
+		LIBS='$(PERL_LIBS)')
 
 doc:
 	$(MAKE) -C Documentation all

-- 
				Petr "Pasky" Baudis
Stuff: http://pasky.or.cz/
A person is just about as big as the things that make them angry.
Previous: Petr BaudisNext: Junio C Hamano
Message 15 of 45 in “x86 asm SHA1 (draft)”
  1. linux@horizon.comJun 23, 2006
  2. Junio C HamanoJun 24, 2006
  3. linux@horizon.comJun 24, 2006
  4. Junio C HamanoJun 24, 2006
  5. From b65bc21e7d8dc8cafc70dfa6354cb66b8874b2d9 Mon Sep 17 00:00:00 2001Junio C Hamano, Jun 24, 2006
  6. linux@horizon.comJun 24, 2006
  7. Junio C HamanoJun 24, 2006
  8. linux@horizon.comJun 24, 2006
  9. PPC SHA-1 Updates in "pu"Junio C Hamano, Jun 24, 2006
  10. Linus TorvaldsJun 24, 2006
  11. Junio C HamanoJun 24, 2006
  12. Linus TorvaldsJun 24, 2006
  13. Junio C HamanoJun 24, 2006
  14. Petr BaudisJun 25, 2006
  15. Git.pm build: Fix quoting and missing GIT-CFLAGS dependencyPetr Baudis, Jun 25, 2006
  16. Junio C HamanoJun 25, 2006
  17. Petr BaudisJun 25, 2006
  18. Junio C HamanoJun 26, 2006
  19. [POOL] Who likes running Git without make install?Petr Baudis, Jul 1, 2006
  20. Junio C HamanoJul 2, 2006
  21. Junio C HamanoJul 2, 2006
  22. Petr BaudisJul 2, 2006
  23. Junio C HamanoJul 2, 2006
  24. Junio C HamanoJul 3, 2006
  25. Petr BaudisJul 3, 2006
  26. Junio C HamanoJul 3, 2006
  27. Petr BaudisJul 3, 2006
  28. Johannes SchindelinJul 3, 2006
  29. Petr BaudisJun 25, 2006
  30. Junio C HamanoJun 25, 2006
  31. Petr BaudisJun 25, 2006
  32. Johannes SchindelinJun 25, 2006
  33. Petr BaudisJun 25, 2006
  34. Junio C HamanoJun 25, 2006
  35. Johannes SchindelinJun 25, 2006
  36. Randal L. SchwartzJun 25, 2006
  37. Johannes SchindelinJun 25, 2006
  38. perl profiling (was: PPC SHA-1 Updates in "pu")Jeff King, Jun 26, 2006
  39. Junio C HamanoJun 26, 2006
  40. GIt.xs merge statusJunio C Hamano, Jun 30, 2006
  41. Pavel RoskinJun 30, 2006
  42. Junio C HamanoJun 30, 2006
  43. Pavel RoskinJun 30, 2006
  44. Johannes SchindelinJun 30, 2006
  45. Junio C HamanoJun 30, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.