Re: PPC SHA-1 Updates in "pu"
- From
Junio C Hamano <junkio@cox.net>
- Date
- Jun 24, 2006, 20:21 UTC
- Message-ID
- <7vhd2atid1.fsf@assigned-by-dhcp.cox.net>
- In-Reply-To
- <Pine.LNX.4.64.0606241147480.6483@g5.osdl.org>
Linus Torvalds <torvalds@osdl.org> writes:
> Also, "pu" in general is totally unusable. It doesn't even compile.
Care to share problems with Pasky and I to take a look at, please?
> I think that "Git.xs" thing is fine for random hacks, but please please > PLEASE don't make any central program depend on it.
I agree. I got really disgusted when I tentatively pulled the current Git.xs into "next" and installed it for my own use to notice that it broke git-fmt-merge-msg hence git-pull workflow.
Pasky, can we first iron out kinks in the build procedure and installation before converting existing programs further? The things I worry about currently are:
- the SITELIBARCH gotcha I sent you a message about (and you responded to it already -- was that an Acked-by?);
- RPM target -- we probably acquired a new build-dependency in which case the .spec file needs to be updated;
- Make sure Git.xs builds and installed result works fine on all platforms we care about, including Cygwin and other non-Linux boxes.
I'd even suggest we revert the changes to git-fmt-merge-msg to keep it working for now, until the above worries are resolved. Otherwise we cannot have it in "next" safely (and I REALLY _do_ want to have Git.pm infrastructure in "next" soonish).
We can start using Git.xs and friends in some _new_ ancillary programs, once we solve building and installing problems for everybody. That way it would help us gain portability and confidence without disrupting existing users.