Re: [PATCH] Git.pm build: Fix quoting and missing GIT-CFLAGS dependency

From: Petr Baudis <pasky@suse.cz>
Date: Jun 25, 2006, 15:21 UTC
Message-ID: <20060625152157.GG21864@pasky.or.cz>
In-Reply-To: <7vac82q6mb.fsf@assigned-by-dhcp.cox.net>

Dear diary, on Sun, Jun 25, 2006 at 05:03:24AM CEST, I got a letter where Junio C Hamano <junkio@cox.net> said that...

Show 6 quoted lines

> During our a handful piecemeal patch exchange back-and-forth on
> the list, most of the patches did not apply mechanically, so I
> rolled them up and have pushed out the result in "pu" and it
> will mirror out shortly.  I am reasonably sure it is in much
> better shape than 24 hours ago; could you double check the
> result for me please?

It looks good; I don't like the makefile changes a lot but more on that below.

Could you please also throw in these two?

[PATCH 3/7] Git.pm: Swap hash_object() parameters [PATCH 4/7] Git.pm: Fix Git->repository("/somewhere/totally/elsewhere")

..snip..

>      - RPM target -- we probably acquired a new build-dependency in
>        which case the .spec file needs to be updated;

..snip..

Show 6 quoted lines

> I think we have cleared SITELIBARCH, and Git.xs building is in
> testable state for wider audience.  The remaining hurdles are to
> make sure the RPM target is still sensible, and fix the test
> scheme.
> 
> Now, I am clueless about RPM, so help is very much appreciated.

Chris, could you help, please? Do we need to insert anything special to builddeps if we build own Perl module?

Show 9 quoted lines

> About the testsuite, I think with the way git-fmt-merge-msg (and
> other Perl scripts that will use Git.pm) is munged on the
> initial line "#!/usr/bin/perl -I$(installedpath)", the test
> scheme is seriously broken.  To see how yourself, have a good
> working version of Git.pm and friends in the path your
> git-fmt-merge-msg's first line points at, apply the following
> patch to perl/Git.pm in your source tree and run "make test".
> It will pass t5700-clone-reference.sh test, which does "git
> pull" (and uses git-fmt-merge-msg) without problems X-<.

Yes, -I is very broken. I have abandoned it in:

	Subject: Re: [PATCH 01/12] Introduce Git.pm (v4)
	Date:   Sat, 24 Jun 2006 13:52:27 +0200

The advantage to your approach is that it works properly without requiring to make install even outside of the testsuite.

> The additional dependency to perl/Makefile is needed regardless
> of this tentative fix -- you cannot run make -C perl before
> building perl/Makefile.

Yes, that bit shall be Acked-by: Petr Baudis <pasky@suse.cz>

-- 
				Petr "Pasky" Baudis
Stuff: http://pasky.or.cz/
A person is just about as big as the things that make them angry.