Re: GIt.xs merge status
- From
- Pavel Roskin <proski@gnu.org>
- Date
- Jun 30, 2006, 05:08 UTC
- Message-ID
- <1151644101.10496.22.camel@dv>
- In-Reply-To
- <7vmzbvmny4.fsf_-_@assigned-by-dhcp.cox.net>
On Thu, 2006-06-29 at 18:28 -0700, Junio C Hamano wrote:
Show 8 quoted lines
> Checking for unpackaged file(s): /usr/lib/rpm/check-files /var/tmp/git-1.4.1.rc2.g5762-1-root-junio > error: Installed (but unpackaged) file(s) found: > /usr/lib64/perl5/5.8.6/x86_64-linux-thread-multi/perllocal.pod > /usr/lib64/perl5/site_perl/5.8.6/x86_64-linux-thread-multi/Error.pm > /usr/lib64/perl5/site_perl/5.8.6/x86_64-linux-thread-multi/Git.pm > /usr/lib64/perl5/site_perl/5.8.6/x86_64-linux-thread-multi/auto/Git/.packlist > /usr/lib64/perl5/site_perl/5.8.6/x86_64-linux-thread-multi/auto/Git/Git.bs > /usr/lib64/perl5/site_perl/5.8.6/x86_64-linux-thread-multi/auto/Git/Git.so
I guess all this perl stuff should be in a separate module perl-Git to comply with Red Hat conventions. This would make git-core depend on perl-Git, but it's OK.
Error.pm is already provided by perl-Error. If we require perl(Error) for building, it won't be installed. Actually, probing for Error.pm is incorrect, so I'm fixing it.
Git.bs, .packlist and perllocal.pod should be removed - that's what other Perl packages do. Red Hat packages use INSTALLDIRS=vendor so that "site_perl" becomes "vendor_perl".
While hacking that, I have wound that "--without doc" is broken in pu, so I'm fixing it as well. The patches will be sent shortly.
-- Regards, Pavel Roskin