Re: x86 asm SHA1 (draft)

From: Junio C Hamano <junkio@cox.net>
Date: Jun 24, 2006, 07:03 UTC
Message-ID: <7vfyhv11ej.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <20060624012202.4822.qmail@science.horizon.com>

linux@horizon.com writes:

Show 10 quoted lines

> Well, I'm not sure it's worth this much trouble.  Both of my PPC
> implementations are smaller and faster than the current one,
> so that's a pretty easy decision.  The difference between them
> is 2-3%, which is, I think, not enough to be worth the maintenance
> burden of a run-time decision infrastructure.  Just pick either one
> and call it a day.
>...
> Not that numbers are bad, but I think that until there's a real
> need for more than a single good-enough version per instruction set,
> this is excessive.

OK. I somehow got an impression that your two versions had quite different performance characteristics on G4 and G5 and there was a real choice. If they are between a few per-cent, then I agree it is not worth doing at all.