Re: [PATCH v8 06/37] hook: implement hookcmd.<name>.skip

From: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date: Mar 12, 2021, 08:49 UTC
Message-ID: <87ft10hi30.fsf@evledraar.gmail.com>
In-Reply-To: <20210311021037.3001235-7-emilyshaffer@google.com>

On Thu, Mar 11 2021, Emily Shaffer wrote:

Show 14 quoted lines

> +	cat >expected <<-EOF &&
> +	no commands configured for hook '\''pre-commit'\''
> +	EOF
> +
> +	git hook list pre-commit >actual &&
> +	test_i18ncmp expected actual
> +'
> +
> +test_expect_success 'git hook list ignores skip referring to unused hookcmd' '
> +	test_config hookcmd.abc.command "/path/abc" --add &&
> +	test_config hookcmd.abc.skip "true" --add &&
> +
> +	cat >expected <<-EOF &&
> +	no commands configured for hook '\''pre-commit'\''

ditto on the "echo" comment in a previous mail, looks like we can avoid both of these entirely.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.