Re: [PATCH v9 02/37] hook: introduce git-hook subcommand

From: Junio C Hamano <gitster@pobox.com>
Date: May 27, 2021, 02:18 UTC
Message-ID: <xmqqim34api3.fsf@gitster.g>
In-Reply-To: <20210527000856.695702-3-emilyshaffer@google.com>

Emily Shaffer <emilyshaffer@google.com> writes:

Show 12 quoted lines

> diff --git a/hook.c b/hook.c
> new file mode 100644
> index 0000000000..d3e28aa73a
> --- /dev/null
> +++ b/hook.c
> @@ -0,0 +1,120 @@
> +#include "cache.h"
> +
> +#include "hook.h"
> +#include "config.h"
> +
> +void free_hook(struct hook *ptr)

Should this be "static" (and be removed from hook.h)? Even after the whole series, nobody outside seems to use this function.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.