Re: [PATCH v8 36/37] run-command: stop thinking about hooks

From: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date: Mar 12, 2021, 09:23 UTC
Message-ID: <87v99wg1xw.fsf@evledraar.gmail.com>
In-Reply-To: <20210311021037.3001235-37-emilyshaffer@google.com>

On Thu, Mar 11 2021, Emily Shaffer wrote:

> hook.h has replaced all run-command.h hook-related functionality.
> run-command.h:run_hooks_le/ve and find_hook are no longer used anywhere
> in the codebase. So, let's delete the dead code - or, in the one case
> where it's still needed, move it to an internal function in hook.c.

Similar to other comments about squashing, I think just having this happen incrementally as we remove whatever is the last user of the function would be better.

E.g. find_hook() is last used in one commit, run_hook*() in another...

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.