From: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date: Fri, 12 Mar 2021 08:49:55 GMT
Subject: Re: [PATCH v8 06/37] hook: implement hookcmd.<name>.skip
Message-ID: <87ft10hi30.fsf@evledraar.gmail.com>
In-Reply-To: <20210311021037.3001235-7-emilyshaffer@google.com>


On Thu, Mar 11 2021, Emily Shaffer wrote:

> +	cat >expected <<-EOF &&
> +	no commands configured for hook '\''pre-commit'\''
> +	EOF
> +
> +	git hook list pre-commit >actual &&
> +	test_i18ncmp expected actual
> +'
> +
> +test_expect_success 'git hook list ignores skip referring to unused hookcmd' '
> +	test_config hookcmd.abc.command "/path/abc" --add &&
> +	test_config hookcmd.abc.skip "true" --add &&
> +
> +	cat >expected <<-EOF &&
> +	no commands configured for hook '\''pre-commit'\''

ditto on the "echo" comment in a previous mail, looks like we can avoid
both of these entirely.