git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v8 00/37] config-based hooks

From
Emily Shaffer <emilyshaffer@google.com>
Date
Mar 17, 2021, 18:41 UTC
Message-ID
<YFJNd6an0eGRC4/p@google.com>
In-Reply-To
<87pn04g0r1.fsf@evledraar.gmail.com>
On Fri, Mar 12, 2021 at 10:49:38AM +0100, Ævar Arnfjörð Bjarmason wrote:
Show 16 quoted lines
> 
> 
> On Thu, Mar 11 2021, Emily Shaffer wrote:
> 
> > Since v7:
> > - Addressed Jonathan Tan's review of part I
> > - Addressed Junio's review of part I and II
> > - Combined parts I and II
> >
> > I think the updates to patch 1 between the rest of the work I've been
> > doing probably have covered Ævar's comments.
> 
> A range-diff between iterations of such a large series would be most
> useful. Do you have a public repo with tags or whatever the different
> versions, for those who'd like an easier way to follow along the
> differing versions than scraping the ML archive?

I am really embarrassed to say that I don't have the branches/tags/whatever up. I have not succeeded in building that habit yet. I'll generate one from my local patches today and send it here.

> 
> While reading this I came up with the following fixup patches on top,
> for discussion, maybe not something you want as-is:

I was a little bit confused reading this fixup without seeing the rest of your review, so I'll revisit this once I get through what else you wrote.

Show 423 quoted lines
> 	
> 	 Documentation/git-hook.txt |  8 +++++
> 	 builtin/bugreport.c        |  8 +++--
> 	 builtin/commit.c           |  3 +-
> 	 builtin/hook.c             | 79 ++++++++++++++++++++--------------------------
> 	 builtin/merge.c            |  3 +-
> 	 builtin/receive-pack.c     | 11 +++----
> 	 hook.c                     | 21 +++++-------
> 	 hook.h                     |  5 +--
> 	 refs.c                     |  4 ++-
> 	 sequencer.c                |  4 ++-
> 	 10 files changed, 73 insertions(+), 73 deletions(-)
> 	
> 	diff --git a/Documentation/git-hook.txt b/Documentation/git-hook.txt
> 	index 4ad31ac360a..5c9af30b43e 100644
> 	--- a/Documentation/git-hook.txt
> 	+++ b/Documentation/git-hook.txt
> 	@@ -150,10 +150,18 @@ message body and cannot be parallelized.
> 	 
> 	 CONFIGURATION
> 	 -------------
> 	+
> 	+The below documentation is the same as what's found in
> 	+linkgit:git-config[1]:
> 	+
> 	 include::config/hook.txt[]
> 	 
> 	 HOOKS
> 	 -----
> 	+
> 	+The below documentation is the same as what's found in
> 	+linkgit:githooks[5]:
> 	+
> 	 include::native-hooks.txt[]
> 	 
> Noted in another reply, including it here for completeness.
> 
> 	 GIT
> 	diff --git a/builtin/bugreport.c b/builtin/bugreport.c
> 	index 04467cd1d3a..b64e53fd625 100644
> 	--- a/builtin/bugreport.c
> 	+++ b/builtin/bugreport.c
> 	@@ -81,9 +81,13 @@ static void get_populated_hooks(struct strbuf *hook_info, int nongit)
> 	 		return;
> 	 	}
> 	 
> 	-	for (i = 0; i < ARRAY_SIZE(hook); i++)
> 	-		if (hook_exists(hook[i], HOOKDIR_USE_CONFIG))
> 	+	for (i = 0; i < ARRAY_SIZE(hook); i++) {
> 	+		struct strbuf config;
> 	+		strbuf_addf(&config, "hook.%s.config", hook[i]);
> 	+		if (hook_exists(hook[i], config.buf, HOOKDIR_USE_CONFIG))
> 	 			strbuf_addf(hook_info, "%s\n", hook[i]);
> 	+		strbuf_release(&config);
> 	+	}
> 	 }
> 
> Less strbuf, see below.
> 	 
> 	 static const char * const bugreport_usage[] = {
> 	diff --git a/builtin/commit.c b/builtin/commit.c
> 	index 31df571f123..fc9f1f5ee58 100644
> 	--- a/builtin/commit.c
> 	+++ b/builtin/commit.c
> 	@@ -984,7 +984,8 @@ static int prepare_to_commit(const char *index_file, const char *prefix,
> 	 		return 0;
> 	 	}
> 	 
> 	-	if (!no_verify && hook_exists("pre-commit", HOOKDIR_USE_CONFIG)) {
> 	+	if (!no_verify && hook_exists("pre-commit", "hook.pre-commit.command",
> 	+				      HOOKDIR_USE_CONFIG)) {
> 	 		/*
> 	 		 * Re-read the index as pre-commit hook could have updated it,
> 	 		 * and write it out as a tree.  We must do this before we invoke
> 
> 
> ..ditto.
> 
> 	diff --git a/builtin/hook.c b/builtin/hook.c
> 	index b4f4adb1dea..d0b56ee47f8 100644
> 	--- a/builtin/hook.c
> 	+++ b/builtin/hook.c
> 	@@ -18,8 +18,6 @@ static enum hookdir_opt should_run_hookdir;
> 	 static int list(int argc, const char **argv, const char *prefix)
> 	 {
> 	 	struct list_head *head, *pos;
> 	-	struct strbuf hookname = STRBUF_INIT;
> 	-	struct strbuf hookdir_annotation = STRBUF_INIT;
> 	 
> 	 	struct option list_options[] = {
> 	 		OPT_END(),
> 	@@ -33,67 +31,60 @@ static int list(int argc, const char **argv, const char *prefix)
> 	 			      builtin_hook_usage, list_options);
> 	 	}
> 	 
> 	-	strbuf_addstr(&hookname, argv[0]);
> 	-
> 	-	head = hook_list(&hookname);
> 	+	head = hook_list(argv[0]);
> 	 
> 	 	if (list_empty(head)) {
> 	 		printf(_("no commands configured for hook '%s'\n"),
> 	-		       hookname.buf);
> 	-		strbuf_release(&hookname);
> 	+		       argv[0]);
> 	 		return 0;
> 	 	}
> 	 
> 	-	switch (should_run_hookdir) {
> 	-		case HOOKDIR_NO:
> 	-			strbuf_addstr(&hookdir_annotation, _(" (will not run)"));
> 	-			break;
> 	-		case HOOKDIR_ERROR:
> 	-			strbuf_addstr(&hookdir_annotation, _(" (will error and not run)"));
> 	-			break;
> 	-		case HOOKDIR_INTERACTIVE:
> 	-			strbuf_addstr(&hookdir_annotation, _(" (will prompt)"));
> 	-			break;
> 	-		case HOOKDIR_WARN:
> 	-			strbuf_addstr(&hookdir_annotation, _(" (will warn but run)"));
> 	-			break;
> 	-		case HOOKDIR_YES:
> 	-		/*
> 	-		 * The default behavior should agree with
> 	-		 * hook.c:configured_hookdir_opt(). HOOKDIR_UNKNOWN should just
> 	-		 * do the default behavior.
> 	-		 */
> 	-		case HOOKDIR_UNKNOWN:
> 	-		default:
> 	-			break;
> 	-	}
> 	-
> 	 	list_for_each(pos, head) {
> 	 		struct hook *item = list_entry(pos, struct hook, list);
> 	 		item = list_entry(pos, struct hook, list);
> 	 		if (item) {
> 	-			/* Don't translate 'hookdir' - it matches the config */
> 	-			printf("%s: %s%s\n",
> 	-			       (item->from_hookdir
> 	+			const char *scope = item->from_hookdir
> 	 				? "hookdir"
> 	-				: config_scope_name(item->origin)),
> 	-			       item->command.buf,
> 	-			       (item->from_hookdir
> 	-				? hookdir_annotation.buf
> 	-				: ""));
> 	+				: config_scope_name(item->origin);
> 	+			switch (should_run_hookdir) {
> 	+			case HOOKDIR_NO:
> 	+				printf(_("%s: %s (will not run)\n"),
> 	+				       scope, item->command.buf);
> 	+				break;
> 	+			case HOOKDIR_ERROR:
> 	+				printf(_("%s: %s (will error and not run)\n"),
> 	+				       scope, item->command.buf);
> 	+				break;
> 	+			case HOOKDIR_INTERACTIVE:
> 	+				printf(_("%s: %s (will prompt)\n"),
> 	+				       scope, item->command.buf);
> 	+				break;
> 	+			case HOOKDIR_WARN:
> 	+				printf(_("%s: %s (will warn but run)\n"),
> 	+				       scope, item->command.buf);
> 	+				break;
> 	+			case HOOKDIR_YES:
> 	+				/*
> 	+				 * The default behavior should agree with
> 	+				 * hook.c:configured_hookdir_opt(). HOOKDIR_UNKNOWN should just
> 	+				 * do the default behavior.
> 	+				 */
> 	+			case HOOKDIR_UNKNOWN:
> 	+			default:
> 	+				printf(_("%s: %s\n"),
> 	+				       scope, item->command.buf);
> 	+				break;
> 	+			}
> 	 		}
> 	 	}
> 	 
> 	 	clear_hook_list(head);
> 	-	strbuf_release(&hookdir_annotation);
> 	-	strbuf_release(&hookname);
> 	 
> 	 	return 0;
> 	 }
> 
> I think this is better to avoid i18n lego, as noted in another reply
> (but I didn't include the patch).
> 
> More on strbuf below:
> 	 
> 	 static int run(int argc, const char **argv, const char *prefix)
> 	 {
> 	-	struct strbuf hookname = STRBUF_INIT;
> 	 	struct run_hooks_opt opt;
> 	 	int rc = 0;
> 	 
> 	@@ -118,12 +109,10 @@ static int run(int argc, const char **argv, const char *prefix)
> 	 		usage_msg_opt(_("You must specify a hook event to run."),
> 	 			      builtin_hook_usage, run_options);
> 	 
> 	-	strbuf_addstr(&hookname, argv[0]);
> 	 	opt.run_hookdir = should_run_hookdir;
> 	 
> 	-	rc = run_hooks(hookname.buf, &opt);
> 	+	rc = run_hooks(argv[0], &opt);
> 	 
> 	-	strbuf_release(&hookname);
> 	 	run_hooks_opt_clear(&opt);
> 	 
> 	 	return rc;
> 	diff --git a/builtin/merge.c b/builtin/merge.c
> 	index 3a2af257a6b..df4ff72fbc7 100644
> 	--- a/builtin/merge.c
> 	+++ b/builtin/merge.c
> 	@@ -848,7 +848,8 @@ static void prepare_to_commit(struct commit_list *remoteheads)
> 	 	 * and write it out as a tree.  We must do this before we invoke
> 	 	 * the editor and after we invoke run_status above.
> 	 	 */
> 	-	if (hook_exists("pre-merge-commit", HOOKDIR_USE_CONFIG))
> 	+	if (hook_exists("pre-merge-commit", "hook.pre-merge-commit.command",
> 	+			HOOKDIR_USE_CONFIG))
> 	 		discard_cache();
> 	 	read_cache_from(index_file);
> 	 	strbuf_addbuf(&msg, &merge_msg);
> 	diff --git a/builtin/receive-pack.c b/builtin/receive-pack.c
> 	index eaedeeb1e8b..a76069ea592 100644
> 	--- a/builtin/receive-pack.c
> 	+++ b/builtin/receive-pack.c
> 	@@ -1123,12 +1123,10 @@ static int run_proc_receive_hook(struct command *commands,
> 	 	int version = 0;
> 	 	int code;
> 	 
> 	-	struct strbuf hookname = STRBUF_INIT;
> 	 	struct hook *proc_receive = NULL;
> 	 	struct list_head *pos, *hooks;
> 	 
> 	-	strbuf_addstr(&hookname, "proc-receive");
> 	-	hooks = hook_list(&hookname);
> 	+	hooks = hook_list("proc-receive");
> 	 
> 	 	list_for_each(pos, hooks) {
> 	 		if (proc_receive) {
> 	@@ -1460,8 +1458,6 @@ static const char *push_to_deploy(unsigned char *sha1,
> 	 	return NULL;
> 	 }
> 	 
> 	-static const char *push_to_checkout_hook = "push-to-checkout";
> 	-
> 	 static const char *push_to_checkout(unsigned char *hash,
> 	 				    struct strvec *env,
> 	 				    const char *work_tree)
> 	@@ -1472,7 +1468,7 @@ static const char *push_to_checkout(unsigned char *hash,
> 	 	strvec_pushf(env, "GIT_WORK_TREE=%s", absolute_path(work_tree));
> 	 	strvec_pushv(&opt.env, env->v);
> 	 	strvec_push(&opt.args, hash_to_hex(hash));
> 	-	if (run_hooks(push_to_checkout_hook, &opt)) {
> 	+	if (run_hooks("push-to-checkout", &opt)) {
> 	 		run_hooks_opt_clear(&opt);
> 	 		return "push-to-checkout hook declined";
> 	 	} else {
> 	@@ -1502,7 +1498,8 @@ static const char *update_worktree(unsigned char *sha1, const struct worktree *w
> 	 
> 	 	strvec_pushf(&env, "GIT_DIR=%s", absolute_path(git_dir));
> 	 
> 	-	if (!hook_exists(push_to_checkout_hook, HOOKDIR_USE_CONFIG))
> 	+	if (!hook_exists("push-to-checkout", "hook.push-to-checkout.command",
> 	+			 HOOKDIR_USE_CONFIG))
> 	 		retval = push_to_deploy(sha1, &env, work_tree);
> 	 	else
> 	 		retval = push_to_checkout(sha1, &env, work_tree);
> 	diff --git a/hook.c b/hook.c
> 	index 7f6f3b9a616..49c3861ce00 100644
> 	--- a/hook.c
> 	+++ b/hook.c
> 	@@ -247,7 +247,7 @@ static const char *find_legacy_hook(const char *name)
> 	 }
> 	 
> 	 
> 	-struct list_head* hook_list(const struct strbuf* hookname)
> 	+struct list_head* hook_list(const char *hookname)
> 	 {
> 	 	struct strbuf hook_key = STRBUF_INIT;
> 	 	struct list_head *hook_head = xmalloc(sizeof(struct list_head));
> 	@@ -256,14 +256,14 @@ struct list_head* hook_list(const struct strbuf* hookname)
> 	 	INIT_LIST_HEAD(hook_head);
> 	 
> 	 	if (!hookname)
> 	-		return NULL;
> 	+		BUG("???");;
> 	 
> 	-	strbuf_addf(&hook_key, "hook.%s.command", hookname->buf);
> 	+	strbuf_addf(&hook_key, "hook.%s.command", hookname);
> 	 
> 	 	git_config(hook_config_lookup, &cb_data);
> 	 
> 	 	if (have_git_dir()) {
> 	-		const char *legacy_hook_path = find_legacy_hook(hookname->buf);
> 	+		const char *legacy_hook_path = find_legacy_hook(hookname);
> 	 
> 	 		/* Unconditionally add legacy hook, but annotate it. */
> 	 		if (legacy_hook_path) {
> 	@@ -300,10 +300,10 @@ void run_hooks_opt_init_async(struct run_hooks_opt *o)
> 	 	o->jobs = configured_hook_jobs();
> 	 }
> 	 
> 	-int hook_exists(const char *hookname, enum hookdir_opt should_run_hookdir)
> 	+int hook_exists(const char *hookname, const char *hook_config,
> 	+		enum hookdir_opt should_run_hookdir)
> 	 {
> 	 	const char *value = NULL; /* throwaway */
> 	-	struct strbuf hook_key = STRBUF_INIT;
> 	 	int could_run_hookdir;
> 	 
> 	 	if (should_run_hookdir == HOOKDIR_USE_CONFIG)
> 	@@ -314,9 +314,7 @@ int hook_exists(const char *hookname, enum hookdir_opt should_run_hookdir)
> 	 				should_run_hookdir == HOOKDIR_YES)
> 	 				&& !!find_legacy_hook(hookname);
> 	 
> 	-	strbuf_addf(&hook_key, "hook.%s.command", hookname);
> 	-
> 	-	return (!git_config_get_value(hook_key.buf, &value)) || could_run_hookdir;
> 	+	return (!git_config_get_value(hook_config, &value)) || could_run_hookdir;
> 	 }
> 	 
> 	 void run_hooks_opt_clear(struct run_hooks_opt *o)
> 	@@ -438,7 +436,6 @@ static int notify_hook_finished(int result,
> 	 
> 	 int run_hooks(const char *hookname, struct run_hooks_opt *options)
> 	 {
> 	-	struct strbuf hookname_str = STRBUF_INIT;
> 	 	struct list_head *to_run, *pos = NULL, *tmp = NULL;
> 	 	struct hook_cb_data cb_data = { 0, NULL, NULL, options };
> 	 
> 	@@ -448,9 +445,7 @@ int run_hooks(const char *hookname, struct run_hooks_opt *options)
> 	 	if (options->path_to_stdin && options->feed_pipe)
> 	 		BUG("choose only one method to populate stdin");
> 	 
> 	-	strbuf_addstr(&hookname_str, hookname);
> 	-
> 	-	to_run = hook_list(&hookname_str);
> 	+	to_run = hook_list(hookname);
> 	 
> 	 	list_for_each_safe(pos, tmp, to_run) {
> 	 		struct hook *hook = list_entry(pos, struct hook, list);
> 	diff --git a/hook.h b/hook.h
> 	index 4ff9999b049..bfbbf36882d 100644
> 	--- a/hook.h
> 	+++ b/hook.h
> 	@@ -26,7 +26,7 @@ struct hook {
> 	  * Provides a linked list of 'struct hook' detailing commands which should run
> 	  * in response to the 'hookname' event, in execution order.
> 	  */
> 	-struct list_head* hook_list(const struct strbuf *hookname);
> 	+struct list_head* hook_list(const char *hookname);
> 	 
> 	 enum hookdir_opt
> 	 {
> 	@@ -123,7 +123,8 @@ void run_hooks_opt_clear(struct run_hooks_opt *o);
> 	  * Like with run_hooks, if you take a --run-hookdir flag, reflect that
> 	  * user-specified behavior here instead.
> 	  */
> 	-int hook_exists(const char *hookname, enum hookdir_opt should_run_hookdir);
> 	+int hook_exists(const char *hookname, const char *hook_config,
> 	+		enum hookdir_opt should_run_hookdir);
> 	 
> 	 /*
> 	  * Runs all hooks associated to the 'hookname' event in order. Each hook will be
> 	diff --git a/refs.c b/refs.c
> 	index 334fdd9103c..f01995fe64f 100644
> 	--- a/refs.c
> 	+++ b/refs.c
> 	@@ -1966,7 +1966,9 @@ static int run_transaction_hook(struct ref_transaction *transaction,
> 	 
> 	 	run_hooks_opt_init_async(&opt);
> 	 
> 	-	if (!hook_exists("reference-transaction", HOOKDIR_USE_CONFIG))
> 	+	if (!hook_exists("reference-transaction",
> 	+			 "hook.reference-transaction.command",
> 	+			 HOOKDIR_USE_CONFIG))
> 	 		return ret;
> 	 
> 	 	strvec_push(&opt.args, state);
> 	diff --git a/sequencer.c b/sequencer.c
> 	index 34ff275f0d1..52c067c1688 100644
> 	--- a/sequencer.c
> 	+++ b/sequencer.c
> 	@@ -1436,7 +1436,9 @@ static int try_to_commit(struct repository *r,
> 	 		}
> 	 	}
> 	 
> 	-	if (hook_exists("prepare-commit-msg", HOOKDIR_USE_CONFIG)) {
> 	+	if (hook_exists("prepare-commit-msg",
> 	+			"hook.prepare-commit-msg.command",
> 	+			HOOKDIR_USE_CONFIG)) {
> 	 		res = run_prepare_commit_msg_hook(r, msg, hook_commit);
> 	 		if (res)
> 	 			goto out;
> 
> There was another reply (from JT I believe, but didn't go back and look
> it up) about the over use of strbuf.
> 
> I tend to agree, as much as I love the API it's really not better to
> write C with it if all you need is a const char* that's never modified,
> particularly if you get it from elsewhere.
> 
> So it's really not meant for or good for "everything we need a const
> char*", but to avoid verbose realloc() dances all over the place, and
> for things like getline() loops without a hardcoded buffer size.
> 
> E.g. in the first hunk here we're creating a strbuf just to copy argv[0]
> to it, and then throwing it away, let's just pass down argv[0].
> 
> For hook_exists I think just having the code more grep-able and having
> the config value inline is better, but I admit that's a matter of taste.
> 
> I didn't try to find all such strbuf() occurrences, anyway, in the
> overall scheme of things it's a relatively small nit.
> 
> I'm hoping to do some deeper diving into this series, in particular the
> parallelism, but just sending the shallow-ish comments I have for now.
> 
> Thanks for working on this!
Previous: Ævar Arnfjörð BjarmasonNext: Emily Shaffer
Message 114 of 479 in “config-based hooks”
  1. 00/37 config-based hooksEmily Shaffer, Mar 11, 2021
  2. 04/37 hook: include hookdir hook in listEmily Shaffer, Mar 11, 2021
  3. Ævar Arnfjörð BjarmasonMar 12, 2021
  4. Emily ShafferMar 24, 2021
  5. Junio C HamanoMar 24, 2021
  6. Eric SunshineMar 24, 2021
  7. Emily ShafferMar 24, 2021
  8. 01/37 doc: propose hooks managed by the configEmily Shaffer, Mar 11, 2021
  9. 05/37 hook: teach hook.runHookDirEmily Shaffer, Mar 11, 2021
  10. Ævar Arnfjörð BjarmasonMar 12, 2021
  11. Emily ShafferMar 24, 2021
  12. Ævar Arnfjörð BjarmasonMar 24, 2021
  13. 07/37 parse-options: parse into strvecEmily Shaffer, Mar 11, 2021
  14. Ævar Arnfjörð BjarmasonMar 12, 2021
  15. Emily ShafferMar 24, 2021
  16. 09/37 hook: introduce hook_exists()Emily Shaffer, Mar 11, 2021
  17. 11/37 run-command: allow stdin for run_processes_parallelEmily Shaffer, Mar 11, 2021
  18. 02/37 hook: scaffolding for git-hook subcommandEmily Shaffer, Mar 11, 2021
  19. 08/37 hook: add 'run' subcommandEmily Shaffer, Mar 11, 2021
  20. Ævar Arnfjörð BjarmasonMar 12, 2021
  21. Emily ShafferMar 24, 2021
  22. Junio C HamanoMar 12, 2021
  23. 10/37 hook: support passing stdin to hooksEmily Shaffer, Mar 11, 2021
  24. Ævar Arnfjörð BjarmasonMar 12, 2021
  25. Junio C HamanoMar 12, 2021
  26. 03/37 hook: add list commandEmily Shaffer, Mar 11, 2021
  27. Ævar Arnfjörð BjarmasonMar 12, 2021
  28. Emily ShafferMar 24, 2021
  29. Ævar Arnfjörð BjarmasonMar 25, 2021
  30. 13/37 hook: allow specifying working directory for hooksEmily Shaffer, Mar 11, 2021
  31. 06/37 hook: implement hookcmd.<name>.skipEmily Shaffer, Mar 11, 2021
  32. Ævar Arnfjörð BjarmasonMar 12, 2021
  33. 14/37 run-command: add stdin callback for parallelizationEmily Shaffer, Mar 11, 2021
  34. 18/37 commit: use config-based hooksEmily Shaffer, Mar 11, 2021
  35. Junio C HamanoMar 12, 2021
  36. 12/37 hook: allow parallel hook executionEmily Shaffer, Mar 11, 2021
  37. 15/37 hook: provide stdin by string_list or callbackEmily Shaffer, Mar 11, 2021
  38. 17/37 hooks: allow callers to capture outputEmily Shaffer, Mar 11, 2021
  39. Ævar Arnfjörð BjarmasonMar 12, 2021
  40. Emily ShafferMar 24, 2021
  41. 21/37 gc: use hook library for pre-auto-gc hookEmily Shaffer, Mar 11, 2021
  42. 19/37 am: convert applypatch hooks to use configEmily Shaffer, Mar 11, 2021
  43. Junio C HamanoMar 12, 2021
  44. Emily ShafferMar 29, 2021
  45. 20/37 merge: use config-based hooks for post-merge hookEmily Shaffer, Mar 11, 2021
  46. 16/37 run-command: allow capturing of collated outputEmily Shaffer, Mar 11, 2021
  47. 22/37 rebase: teach pre-rebase to use hook.hEmily Shaffer, Mar 11, 2021
  48. Junio C HamanoMar 12, 2021
  49. 26/37 hooks: convert 'post-checkout' hook to hook libraryEmily Shaffer, Mar 11, 2021
  50. 23/37 read-cache: convert post-index-change hook to use configEmily Shaffer, Mar 11, 2021
  51. Junio C HamanoMar 12, 2021
  52. Emily ShafferMar 29, 2021
  53. 29/37 reference-transaction: look for hooks in configEmily Shaffer, Mar 11, 2021
  54. 28/37 transport: convert pre-push hook to use configEmily Shaffer, Mar 11, 2021
  55. 27/37 hook: convert 'post-rewrite' hook to configEmily Shaffer, Mar 11, 2021
  56. 30/37 receive-pack: convert 'update' hook to hook.hEmily Shaffer, Mar 11, 2021
  57. 24/37 receive-pack: convert push-to-checkout hook to hook.hEmily Shaffer, Mar 11, 2021
  58. Junio C HamanoMar 12, 2021
  59. Emily ShafferMar 29, 2021
  60. Junio C HamanoMar 30, 2021
  61. 25/37 git-p4: use 'git hook' to run hooksEmily Shaffer, Mar 11, 2021
  62. 32/37 post-update: use hook.h libraryEmily Shaffer, Mar 11, 2021
  63. Ævar Arnfjörð BjarmasonMar 12, 2021
  64. Emily ShafferMar 30, 2021
  65. 31/37 proc-receive: acquire hook list from hook.hEmily Shaffer, Mar 11, 2021
  66. 34/37 bugreport: use hook_exists instead of find_hookEmily Shaffer, Mar 11, 2021
  67. 33/37 receive-pack: convert receive hooks to hook.hEmily Shaffer, Mar 11, 2021
  68. 35/37 git-send-email: use 'git hook run' for 'sendemail-validate'Emily Shaffer, Mar 11, 2021
  69. Ævar Arnfjörð BjarmasonMar 12, 2021
  70. Emily ShafferMar 30, 2021
  71. Emily ShafferMar 31, 2021
  72. Junio C HamanoMar 31, 2021
  73. Emily ShafferApr 1, 2021
  74. Junio C HamanoApr 1, 2021
  75. 0/2 git-send-email: refactor duplicate $? checks into a functionÆvar Arnfjörð Bjarmason, Apr 2, 2021
  76. 2/2 git-send-email: refactor duplicate $? checks into a functionÆvar Arnfjörð Bjarmason, Apr 2, 2021
  77. Junio C HamanoApr 2, 2021
  78. 1/2 git-send-email: replace "map" in void context with "for"Ævar Arnfjörð Bjarmason, Apr 2, 2021
  79. Junio C HamanoApr 2, 2021
  80. Emily ShafferApr 2, 2021
  81. 0/4 refactor duplicate $? checks into a function + improve errorsÆvar Arnfjörð Bjarmason, Apr 4, 2021
  82. 1/4 git-send-email: replace "map" in void context with "for"Ævar Arnfjörð Bjarmason, Apr 4, 2021
  83. 3/4 git-send-email: test full --validate outputÆvar Arnfjörð Bjarmason, Apr 4, 2021
  84. 4/4 git-send-email: improve --validate error outputÆvar Arnfjörð Bjarmason, Apr 4, 2021
  85. Junio C HamanoApr 5, 2021
  86. 2/4 git-send-email: refactor duplicate $? checks into a functionÆvar Arnfjörð Bjarmason, Apr 4, 2021
  87. Junio C HamanoApr 5, 2021
  88. Junio C HamanoApr 5, 2021
  89. Junio C HamanoApr 8, 2021
  90. Junio C HamanoApr 8, 2021
  91. Ævar Arnfjörð BjarmasonApr 8, 2021
  92. Junio C HamanoApr 9, 2021
  93. Emily ShafferMay 3, 2021
  94. 0/3 refactor duplicate $? checks into a function + improve errorsÆvar Arnfjörð Bjarmason, Apr 6, 2021
  95. 1/3 git-send-email: test full --validate outputÆvar Arnfjörð Bjarmason, Apr 6, 2021
  96. 2/3 git-send-email: refactor duplicate $? checks into a functionÆvar Arnfjörð Bjarmason, Apr 6, 2021
  97. 3/3 git-send-email: improve --validate error outputÆvar Arnfjörð Bjarmason, Apr 6, 2021
  98. Junio C HamanoApr 6, 2021
  99. Emily ShafferMar 12, 2021
  100. 36/37 run-command: stop thinking about hooksEmily Shaffer, Mar 11, 2021
  101. Ævar Arnfjörð BjarmasonMar 12, 2021
  102. Emily ShafferMar 30, 2021
  103. 37/37 docs: unify githooks and git-hook manpagesEmily Shaffer, Mar 11, 2021
  104. Ævar Arnfjörð BjarmasonMar 12, 2021
  105. Emily ShafferMar 30, 2021
  106. Junio C HamanoApr 7, 2021
  107. Jeff HostetlerApr 8, 2021
  108. Junio C HamanoApr 8, 2021
  109. Emily ShafferApr 8, 2021
  110. Junio C HamanoApr 9, 2021
  111. Junio C HamanoMar 11, 2021
  112. Emily ShafferMar 12, 2021
  113. Ævar Arnfjörð BjarmasonMar 12, 2021
  114. Emily ShafferMar 17, 2021
  115. Emily ShafferMar 17, 2021
  116. Ævar Arnfjörð BjarmasonMar 12, 2021
  117. Ævar Arnfjörð BjarmasonMar 25, 2021
  118. 00/37 propose config-based hooksEmily Shaffer, May 27, 2021
  119. 01/37 doc: propose hooks managed by the configEmily Shaffer, May 27, 2021
  120. 02/37 hook: introduce git-hook subcommandEmily Shaffer, May 27, 2021
  121. Junio C HamanoMay 27, 2021
  122. 03/37 hook: include hookdir hook in listEmily Shaffer, May 27, 2021
  123. 04/37 hook: teach hook.runHookDirEmily Shaffer, May 27, 2021
  124. 05/37 hook: implement hookcmd.<name>.skipEmily Shaffer, May 27, 2021
  125. 06/37 parse-options: parse into strvecEmily Shaffer, May 27, 2021
  126. 08/37 hook: introduce hook_exists()Emily Shaffer, May 27, 2021
  127. 07/37 hook: add 'run' subcommandEmily Shaffer, May 27, 2021
  128. Ævar Arnfjörð BjarmasonJun 3, 2021
  129. Junio C HamanoJun 3, 2021
  130. 09/37 hook: support passing stdin to hooksEmily Shaffer, May 27, 2021
  131. 10/37 run-command: allow stdin for run_processes_parallelEmily Shaffer, May 27, 2021
  132. 11/37 hook: allow parallel hook executionEmily Shaffer, May 27, 2021
  133. 12/37 hook: allow specifying working directory for hooksEmily Shaffer, May 27, 2021
  134. 13/37 run-command: add stdin callback for parallelizationEmily Shaffer, May 27, 2021
  135. 14/37 hook: provide stdin by string_list or callbackEmily Shaffer, May 27, 2021
  136. 15/37 run-command: allow capturing of collated outputEmily Shaffer, May 27, 2021
  137. 16/37 hooks: allow callers to capture outputEmily Shaffer, May 27, 2021
  138. 17/37 commit: use config-based hooksEmily Shaffer, May 27, 2021
  139. 18/37 am: convert applypatch hooks to use configEmily Shaffer, May 27, 2021
  140. 19/37 merge: use config-based hooks for post-merge hookEmily Shaffer, May 27, 2021
  141. 20/37 gc: use hook library for pre-auto-gc hookEmily Shaffer, May 27, 2021
  142. 21/37 rebase: teach pre-rebase to use hook.hEmily Shaffer, May 27, 2021
  143. 22/37 read-cache: convert post-index-change hook to use configEmily Shaffer, May 27, 2021
  144. Ævar Arnfjörð BjarmasonMay 27, 2021
  145. Taylor BlauMay 28, 2021
  146. Felipe ContrerasMay 31, 2021
  147. 23/37 receive-pack: convert push-to-checkout hook to hook.hEmily Shaffer, May 27, 2021
  148. 24/37 git-p4: use 'git hook' to run hooksEmily Shaffer, May 27, 2021
  149. 25/37 hooks: convert 'post-checkout' hook to hook libraryEmily Shaffer, May 27, 2021
  150. 26/37 hook: convert 'post-rewrite' hook to configEmily Shaffer, May 27, 2021
  151. 27/37 transport: convert pre-push hook to use configEmily Shaffer, May 27, 2021
  152. 28/37 reference-transaction: look for hooks in configEmily Shaffer, May 27, 2021
  153. 29/37 receive-pack: convert 'update' hook to hook.hEmily Shaffer, May 27, 2021
  154. 30/37 proc-receive: acquire hook list from hook.hEmily Shaffer, May 27, 2021
  155. 31/37 post-update: use hook.h libraryEmily Shaffer, May 27, 2021
  156. Ævar Arnfjörð BjarmasonJun 14, 2021
  157. 32/37 receive-pack: convert receive hooks to hook.hEmily Shaffer, May 27, 2021
  158. 33/37 bugreport: use hook_exists instead of find_hookEmily Shaffer, May 27, 2021
  159. 34/37 git-send-email: use 'git hook run' for 'sendemail-validate'Emily Shaffer, May 27, 2021
  160. Ævar Arnfjörð BjarmasonMay 27, 2021
  161. 35/37 run-command: stop thinking about hooksEmily Shaffer, May 27, 2021
  162. 36/37 doc: clarify fsmonitor-watchman specificationEmily Shaffer, May 27, 2021
  163. 37/37 docs: link githooks and git-hook manpagesEmily Shaffer, May 27, 2021
  164. Ævar Arnfjörð BjarmasonJun 3, 2021
  165. Ævar Arnfjörð BjarmasonMay 27, 2021
  166. Ævar Arnfjörð BjarmasonMay 27, 2021
  167. Felipe ContrerasMay 27, 2021
  168. 00/31 minimal restart of "config-based-hooks"Ævar Arnfjörð Bjarmason, May 28, 2021
  169. 01/31 hooks tests: don't leave "actual" nonexisting on failureÆvar Arnfjörð Bjarmason, May 28, 2021
  170. 02/31 gc tests: add a test for the "pre-auto-gc" hookÆvar Arnfjörð Bjarmason, May 28, 2021
  171. 03/31 hook: add 'run' subcommandÆvar Arnfjörð Bjarmason, May 28, 2021
  172. 04/31 run-command.h: move find_hook() to hook.hÆvar Arnfjörð Bjarmason, May 28, 2021
  173. 05/31 hook.c: add a hook_exists() wrapper and use it in bugreport.cÆvar Arnfjörð Bjarmason, May 28, 2021
  174. 06/31 gc: use hook library for pre-auto-gc hookÆvar Arnfjörð Bjarmason, May 28, 2021
  175. 08/31 am: convert applypatch hooks to use configÆvar Arnfjörð Bjarmason, May 28, 2021
  176. 07/31 rebase: teach pre-rebase to use hook.hÆvar Arnfjörð Bjarmason, May 28, 2021
  177. 09/31 hooks: convert 'post-checkout' hook to hook libraryÆvar Arnfjörð Bjarmason, May 28, 2021
  178. 10/31 merge: use config-based hooks for post-merge hookÆvar Arnfjörð Bjarmason, May 28, 2021
  179. 11/31 git hook run: add an --ignore-missing flagÆvar Arnfjörð Bjarmason, May 28, 2021
  180. 12/31 send-email: use 'git hook run' for 'sendemail-validate'Ævar Arnfjörð Bjarmason, May 28, 2021
  181. 13/31 git-p4: use 'git hook' to run hooksÆvar Arnfjörð Bjarmason, May 28, 2021
  182. 14/31 commit: use hook.h to execute hooksÆvar Arnfjörð Bjarmason, May 28, 2021
  183. 15/31 read-cache: convert post-index-change hook to use configÆvar Arnfjörð Bjarmason, May 28, 2021
  184. 16/31 receive-pack: convert push-to-checkout hook to hook.hÆvar Arnfjörð Bjarmason, May 28, 2021
  185. Felipe ContrerasJun 2, 2021
  186. 19/31 am: convert 'post-rewrite' hook to hook.hÆvar Arnfjörð Bjarmason, May 28, 2021
  187. 17/31 run-command: allow stdin for run_processes_parallelÆvar Arnfjörð Bjarmason, May 28, 2021
  188. 18/31 hook: support passing stdin to hooksÆvar Arnfjörð Bjarmason, May 28, 2021
  189. 20/31 run-command: add stdin callback for parallelizationÆvar Arnfjörð Bjarmason, May 28, 2021
  190. 21/31 hook: provide stdin by string_list or callbackÆvar Arnfjörð Bjarmason, May 28, 2021
  191. Felipe ContrerasJun 2, 2021
  192. 22/31 hook: convert 'post-rewrite' hook in sequencer.c to hook.hÆvar Arnfjörð Bjarmason, May 28, 2021
  193. 23/31 transport: convert pre-push hook to use configÆvar Arnfjörð Bjarmason, May 28, 2021
  194. 24/31 reference-transaction: use hook.h to run hooksÆvar Arnfjörð Bjarmason, May 28, 2021
  195. 25/31 run-command: allow capturing of collated outputÆvar Arnfjörð Bjarmason, May 28, 2021
  196. 26/31 hooks: allow callers to capture outputÆvar Arnfjörð Bjarmason, May 28, 2021
  197. 28/31 post-update: use hook.h libraryÆvar Arnfjörð Bjarmason, May 28, 2021
  198. 27/31 receive-pack: convert 'update' hook to hook.hÆvar Arnfjörð Bjarmason, May 28, 2021
  199. Felipe ContrerasJun 2, 2021
  200. 29/31 receive-pack: convert receive hooks to hook.hÆvar Arnfjörð Bjarmason, May 28, 2021
  201. 30/31 hooks: fix a TOCTOU in "did we run a hook?" heuristicÆvar Arnfjörð Bjarmason, May 28, 2021
  202. Bagas SanjayaMay 28, 2021
  203. Ævar Arnfjörð BjarmasonMay 28, 2021
  204. 31/31 hook-list.h: add a generated list of hooks, like config-list.hÆvar Arnfjörð Bjarmason, May 28, 2021
  205. Ævar Arnfjörð BjarmasonJun 1, 2021
  206. Emily ShafferJun 1, 2021
  207. Derrick StoleeJun 1, 2021
  208. Felipe ContrerasJun 2, 2021
  209. Ævar Arnfjörð BjarmasonJun 2, 2021
  210. Ævar Arnfjörð BjarmasonJun 2, 2021
  211. Felipe ContrerasJun 2, 2021
  212. Ævar Arnfjörð BjarmasonJun 2, 2021
  213. Ævar Arnfjörð BjarmasonJun 2, 2021
  214. Felipe ContrerasJun 25, 2021
  215. 00/30 Minimal restart of "config-based-hooks"Ævar Arnfjörð Bjarmason, Jun 14, 2021
  216. 03/30 hook.c: add a hook_exists() wrapper and use it in bugreport.cÆvar Arnfjörð Bjarmason, Jun 14, 2021
  217. 01/30 hook: add 'run' subcommandÆvar Arnfjörð Bjarmason, Jun 14, 2021
  218. Emily ShafferJun 14, 2021
  219. Ævar Arnfjörð BjarmasonJun 15, 2021
  220. Emily ShafferJun 18, 2021
  221. Ævar Arnfjörð BjarmasonJun 20, 2021
  222. Junio C HamanoJun 21, 2021
  223. Emily ShafferJun 22, 2021
  224. Junio C HamanoJun 29, 2021
  225. Felipe ContrerasJun 25, 2021
  226. Felipe ContrerasJun 25, 2021
  227. 02/30 run-command.h: move find_hook() to hook.hÆvar Arnfjörð Bjarmason, Jun 14, 2021
  228. 12/30 commit: use hook.h to execute hooksÆvar Arnfjörð Bjarmason, Jun 14, 2021
  229. 13/30 read-cache: convert post-index-change hook to use configÆvar Arnfjörð Bjarmason, Jun 14, 2021
  230. Felipe ContrerasJun 25, 2021
  231. 09/30 git hook run: add an --ignore-missing flagÆvar Arnfjörð Bjarmason, Jun 14, 2021
  232. 07/30 hooks: convert 'post-checkout' hook to hook libraryÆvar Arnfjörð Bjarmason, Jun 14, 2021
  233. 06/30 am: convert applypatch hooks to use configÆvar Arnfjörð Bjarmason, Jun 14, 2021
  234. 05/30 rebase: teach pre-rebase to use hook.hÆvar Arnfjörð Bjarmason, Jun 14, 2021
  235. 04/30 gc: use hook library for pre-auto-gc hookÆvar Arnfjörð Bjarmason, Jun 14, 2021
  236. Emily ShafferJun 14, 2021
  237. 08/30 merge: use config-based hooks for post-merge hookÆvar Arnfjörð Bjarmason, Jun 14, 2021
  238. 11/30 git-p4: use 'git hook' to run hooksÆvar Arnfjörð Bjarmason, Jun 14, 2021
  239. 16/30 run-command: allow stdin for run_processes_parallelÆvar Arnfjörð Bjarmason, Jun 14, 2021
  240. 17/30 hook: support passing stdin to hooksÆvar Arnfjörð Bjarmason, Jun 14, 2021
  241. 10/30 send-email: use 'git hook run' for 'sendemail-validate'Ævar Arnfjörð Bjarmason, Jun 14, 2021
  242. 26/30 receive-pack: convert 'update' hook to hook.hÆvar Arnfjörð Bjarmason, Jun 14, 2021
  243. 15/30 run-command: remove old run_hook_{le,ve}() hook APIÆvar Arnfjörð Bjarmason, Jun 14, 2021
  244. Felipe ContrerasJun 25, 2021
  245. 29/30 hooks: fix a TOCTOU in "did we run a hook?" heuristicÆvar Arnfjörð Bjarmason, Jun 14, 2021
  246. 14/30 receive-pack: convert push-to-checkout hook to hook.hÆvar Arnfjörð Bjarmason, Jun 14, 2021
  247. 18/30 am: convert 'post-rewrite' hook to hook.hÆvar Arnfjörð Bjarmason, Jun 14, 2021
  248. 23/30 reference-transaction: use hook.h to run hooksÆvar Arnfjörð Bjarmason, Jun 14, 2021
  249. 20/30 hook: provide stdin by string_list or callbackÆvar Arnfjörð Bjarmason, Jun 14, 2021
  250. 22/30 transport: convert pre-push hook to use configÆvar Arnfjörð Bjarmason, Jun 14, 2021
  251. 19/30 run-command: add stdin callback for parallelizationÆvar Arnfjörð Bjarmason, Jun 14, 2021
  252. 21/30 hook: convert 'post-rewrite' hook in sequencer.c to hook.hÆvar Arnfjörð Bjarmason, Jun 14, 2021
  253. 30/30 hook-list.h: add a generated list of hooks, like config-list.hÆvar Arnfjörð Bjarmason, Jun 14, 2021
  254. Ævar Arnfjörð BjarmasonJun 15, 2021
  255. 27/30 post-update: use hook.h libraryÆvar Arnfjörð Bjarmason, Jun 14, 2021
  256. 25/30 hooks: allow callers to capture outputÆvar Arnfjörð Bjarmason, Jun 14, 2021
  257. 24/30 run-command: allow capturing of collated outputÆvar Arnfjörð Bjarmason, Jun 14, 2021
  258. 28/30 receive-pack: convert receive hooks to hook.hÆvar Arnfjörð Bjarmason, Jun 14, 2021
  259. Emily ShafferJun 14, 2021
  260. Junio C HamanoJun 16, 2021
  261. 00/27 Base for "config-based-hooks"Ævar Arnfjörð Bjarmason, Jun 17, 2021
  262. 01/27 hook: add 'run' subcommandÆvar Arnfjörð Bjarmason, Jun 17, 2021
  263. 04/27 am: convert applypatch hooks to use configÆvar Arnfjörð Bjarmason, Jun 17, 2021
  264. 06/27 merge: use config-based hooks for post-merge hookÆvar Arnfjörð Bjarmason, Jun 17, 2021
  265. 02/27 gc: use hook library for pre-auto-gc hookÆvar Arnfjörð Bjarmason, Jun 17, 2021
  266. Emily ShafferJul 22, 2021
  267. 03/27 rebase: teach pre-rebase to use hook.hÆvar Arnfjörð Bjarmason, Jun 17, 2021
  268. 05/27 hooks: convert 'post-checkout' hook to hook libraryÆvar Arnfjörð Bjarmason, Jun 17, 2021
  269. 09/27 git-p4: use 'git hook' to run hooksÆvar Arnfjörð Bjarmason, Jun 17, 2021
  270. 07/27 git hook run: add an --ignore-missing flagÆvar Arnfjörð Bjarmason, Jun 17, 2021
  271. Emily ShafferJul 2, 2021
  272. 08/27 send-email: use 'git hook run' for 'sendemail-validate'Ævar Arnfjörð Bjarmason, Jun 17, 2021
  273. 10/27 commit: use hook.h to execute hooksÆvar Arnfjörð Bjarmason, Jun 17, 2021
  274. 12/27 receive-pack: convert push-to-checkout hook to hook.hÆvar Arnfjörð Bjarmason, Jun 17, 2021
  275. 13/27 run-command: remove old run_hook_{le,ve}() hook APIÆvar Arnfjörð Bjarmason, Jun 17, 2021
  276. 14/27 run-command: allow stdin for run_processes_parallelÆvar Arnfjörð Bjarmason, Jun 17, 2021
  277. 15/27 hook: support passing stdin to hooksÆvar Arnfjörð Bjarmason, Jun 17, 2021
  278. 11/27 read-cache: convert post-index-change hook to use configÆvar Arnfjörð Bjarmason, Jun 17, 2021
  279. 16/27 am: convert 'post-rewrite' hook to hook.hÆvar Arnfjörð Bjarmason, Jun 17, 2021
  280. 17/27 run-command: add stdin callback for parallelizationÆvar Arnfjörð Bjarmason, Jun 17, 2021
  281. 18/27 hook: provide stdin by string_list or callbackÆvar Arnfjörð Bjarmason, Jun 17, 2021
  282. 19/27 hook: convert 'post-rewrite' hook in sequencer.c to hook.hÆvar Arnfjörð Bjarmason, Jun 17, 2021
  283. 20/27 transport: convert pre-push hook to use configÆvar Arnfjörð Bjarmason, Jun 17, 2021
  284. 22/27 run-command: allow capturing of collated outputÆvar Arnfjörð Bjarmason, Jun 17, 2021
  285. 21/27 reference-transaction: use hook.h to run hooksÆvar Arnfjörð Bjarmason, Jun 17, 2021
  286. 23/27 hooks: allow callers to capture outputÆvar Arnfjörð Bjarmason, Jun 17, 2021
  287. 24/27 receive-pack: convert 'update' hook to hook.hÆvar Arnfjörð Bjarmason, Jun 17, 2021
  288. 25/27 post-update: use hook.h libraryÆvar Arnfjörð Bjarmason, Jun 17, 2021
  289. 26/27 receive-pack: convert receive hooks to hook.hÆvar Arnfjörð Bjarmason, Jun 17, 2021
  290. 27/27 hooks: fix a TOCTOU in "did we run a hook?" heuristicÆvar Arnfjörð Bjarmason, Jun 17, 2021
  291. Emily ShafferJun 18, 2021
  292. 0/9 config-based hooks restartedEmily Shaffer, Jul 15, 2021
  293. 1/9 hook: run a list of hooks insteadEmily Shaffer, Jul 15, 2021
  294. 2/9 hook: allow parallel hook executionEmily Shaffer, Jul 15, 2021
  295. Ævar Arnfjörð BjarmasonJul 16, 2021
  296. Emily ShafferJul 22, 2021
  297. Ævar Arnfjörð BjarmasonJul 23, 2021
  298. 5/9 hook: allow running non-native hooksEmily Shaffer, Jul 15, 2021
  299. 4/9 hook: treat hookdir hook speciallyEmily Shaffer, Jul 15, 2021
  300. Ævar Arnfjörð BjarmasonJul 16, 2021
  301. Emily ShafferJul 22, 2021
  302. Ævar Arnfjörð BjarmasonJul 23, 2021
  303. Felipe ContrerasJul 23, 2021
  304. Eric SunshineJul 23, 2021
  305. Felipe ContrerasJul 23, 2021
  306. 3/9 hook: introduce "git hook list"Emily Shaffer, Jul 15, 2021
  307. Ævar Arnfjörð BjarmasonJul 16, 2021
  308. Emily ShafferJul 22, 2021
  309. Ævar Arnfjörð BjarmasonJul 23, 2021
  310. 6/9 hook: include hooks from the configEmily Shaffer, Jul 15, 2021
  311. Ævar Arnfjörð BjarmasonJul 16, 2021
  312. Emily ShafferJul 22, 2021
  313. Ævar Arnfjörð BjarmasonJul 23, 2021
  314. 8/9 hook: teach 'hookcmd' config to alias hook scriptsEmily Shaffer, Jul 15, 2021
  315. Ævar Arnfjörð BjarmasonJul 16, 2021
  316. Emily ShafferJul 22, 2021
  317. Ævar Arnfjörð BjarmasonJul 23, 2021
  318. Emily ShafferAug 4, 2021
  319. Ævar Arnfjörð BjarmasonAug 5, 2021
  320. Emily ShafferAug 5, 2021
  321. Ævar Arnfjörð BjarmasonAug 5, 2021
  322. Emily ShafferAug 6, 2021
  323. Jonathan TanAug 4, 2021
  324. 7/9 hook: allow out-of-repo 'git hook' invocationsEmily Shaffer, Jul 15, 2021
  325. Ævar Arnfjörð BjarmasonJul 16, 2021
  326. Emily ShafferJul 22, 2021
  327. Ævar Arnfjörð BjarmasonJul 23, 2021
  328. 9/9 hook: implement hookcmd.<name>.skipEmily Shaffer, Jul 15, 2021
  329. Emily ShafferJul 28, 2021
  330. 00/36 Run hooks via "git run hook" & hook libraryÆvar Arnfjörð Bjarmason, Aug 3, 2021
  331. 01/36 Makefile: mark "check" target as .PHONYÆvar Arnfjörð Bjarmason, Aug 3, 2021
  332. Emily ShafferAug 20, 2021
  333. 02/36 Makefile: stop hardcoding {command,config}-list.hÆvar Arnfjörð Bjarmason, Aug 3, 2021
  334. Emily ShafferAug 20, 2021
  335. Ævar Arnfjörð BjarmasonAug 24, 2021
  336. 03/36 Makefile: remove an out-of-date commentÆvar Arnfjörð Bjarmason, Aug 3, 2021
  337. Emily ShafferAug 20, 2021
  338. 04/36 hook.[ch]: move find_hook() to this new libraryÆvar Arnfjörð Bjarmason, Aug 3, 2021
  339. Emily ShafferAug 20, 2021
  340. 05/36 hook.c: add a hook_exists() wrapper and use it in bugreport.cÆvar Arnfjörð Bjarmason, Aug 3, 2021
  341. Emily ShafferAug 20, 2021
  342. 07/36 hook-list.h: add a generated list of hooks, like config-list.hÆvar Arnfjörð Bjarmason, Aug 3, 2021
  343. 06/36 hook.c users: use "hook_exists()" insted of "find_hook()"Ævar Arnfjörð Bjarmason, Aug 3, 2021
  344. Emily ShafferAug 20, 2021
  345. 08/36 hook: add 'run' subcommandÆvar Arnfjörð Bjarmason, Aug 3, 2021
  346. Ævar Arnfjörð BjarmasonAug 4, 2021
  347. 12/36 hooks: convert 'post-checkout' hook to hook libraryÆvar Arnfjörð Bjarmason, Aug 3, 2021
  348. 09/36 gc: use hook library for pre-auto-gc hookÆvar Arnfjörð Bjarmason, Aug 3, 2021
  349. 10/36 rebase: convert pre-rebase to use hook.hÆvar Arnfjörð Bjarmason, Aug 3, 2021
  350. 11/36 am: convert applypatch to use hook.hÆvar Arnfjörð Bjarmason, Aug 3, 2021
  351. 13/36 merge: convert post-merge to use hook.hÆvar Arnfjörð Bjarmason, Aug 3, 2021
  352. 14/36 git hook run: add an --ignore-missing flagÆvar Arnfjörð Bjarmason, Aug 3, 2021
  353. 15/36 send-email: use 'git hook run' for 'sendemail-validate'Ævar Arnfjörð Bjarmason, Aug 3, 2021
  354. 16/36 git-p4: use 'git hook' to run hooksÆvar Arnfjörð Bjarmason, Aug 3, 2021
  355. 17/36 commit: convert {pre-commit,prepare-commit-msg} hook to hook.hÆvar Arnfjörð Bjarmason, Aug 3, 2021
  356. 18/36 read-cache: convert post-index-change to use hook.hÆvar Arnfjörð Bjarmason, Aug 3, 2021
  357. 19/36 receive-pack: convert push-to-checkout hook to hook.hÆvar Arnfjörð Bjarmason, Aug 3, 2021
  358. 20/36 run-command: remove old run_hook_{le,ve}() hook APIÆvar Arnfjörð Bjarmason, Aug 3, 2021
  359. 21/36 run-command: allow stdin for run_processes_parallelÆvar Arnfjörð Bjarmason, Aug 3, 2021
  360. 22/36 hook: support passing stdin to hooksÆvar Arnfjörð Bjarmason, Aug 3, 2021
  361. 24/36 run-command: add stdin callback for parallelizationÆvar Arnfjörð Bjarmason, Aug 3, 2021
  362. 23/36 am: convert 'post-rewrite' hook to hook.hÆvar Arnfjörð Bjarmason, Aug 3, 2021
  363. 26/36 hook: convert 'post-rewrite' hook in sequencer.c to hook.hÆvar Arnfjörð Bjarmason, Aug 3, 2021
  364. 25/36 hook: provide stdin by string_list or callbackÆvar Arnfjörð Bjarmason, Aug 3, 2021
  365. 27/36 transport: convert pre-push hook to hook.hÆvar Arnfjörð Bjarmason, Aug 3, 2021
  366. 28/36 hook tests: test for exact "pre-push" hook inputÆvar Arnfjörð Bjarmason, Aug 3, 2021
  367. Emily ShafferAug 20, 2021
  368. 29/36 hook tests: use a modern style for "pre-push" testsÆvar Arnfjörð Bjarmason, Aug 3, 2021
  369. Emily ShafferAug 20, 2021
  370. 30/36 reference-transaction: use hook.h to run hooksÆvar Arnfjörð Bjarmason, Aug 3, 2021
  371. 32/36 hooks: allow callers to capture outputÆvar Arnfjörð Bjarmason, Aug 3, 2021
  372. 31/36 run-command: allow capturing of collated outputÆvar Arnfjörð Bjarmason, Aug 3, 2021
  373. 33/36 receive-pack: convert 'update' hook to hook.hÆvar Arnfjörð Bjarmason, Aug 3, 2021
  374. 36/36 hooks: fix a TOCTOU in "did we run a hook?" heuristicÆvar Arnfjörð Bjarmason, Aug 3, 2021
  375. 34/36 post-update: use hook.h libraryÆvar Arnfjörð Bjarmason, Aug 3, 2021
  376. 35/36 receive-pack: convert receive hooks to hook.hÆvar Arnfjörð Bjarmason, Aug 3, 2021
  377. 0/6 config-based hooks restartedEmily Shaffer, Aug 12, 2021
  378. 1/6 hook: run a list of hooks insteadEmily Shaffer, Aug 12, 2021
  379. Junio C HamanoAug 12, 2021
  380. Emily ShafferAug 16, 2021
  381. 2/6 hook: allow parallel hook executionEmily Shaffer, Aug 12, 2021
  382. Junio C HamanoAug 12, 2021
  383. Emily ShafferAug 16, 2021
  384. 3/6 hook: introduce "git hook list"Emily Shaffer, Aug 12, 2021
  385. Junio C HamanoAug 12, 2021
  386. Emily ShafferAug 17, 2021
  387. 4/6 hook: allow running non-native hooksEmily Shaffer, Aug 12, 2021
  388. Junio C HamanoAug 12, 2021
  389. Emily ShafferAug 18, 2021
  390. Emily ShafferAug 18, 2021
  391. Junio C HamanoAug 18, 2021
  392. 5/6 hook: include hooks from the configEmily Shaffer, Aug 12, 2021
  393. Junio C HamanoAug 12, 2021
  394. Emily ShafferAug 19, 2021
  395. 6/6 hook: allow out-of-repo 'git hook' invocationsEmily Shaffer, Aug 12, 2021
  396. Junio C HamanoAug 12, 2021
  397. Junio C HamanoAug 12, 2021
  398. Emily ShafferAug 16, 2021
  399. 0/6 config-based hooks restartedEmily Shaffer, Aug 19, 2021
  400. 1/6 hook: run a list of hooks insteadEmily Shaffer, Aug 19, 2021
  401. Ævar Arnfjörð BjarmasonAug 24, 2021
  402. Emily ShafferAug 26, 2021
  403. Ævar Arnfjörð BjarmasonAug 27, 2021
  404. 2/6 hook: allow parallel hook executionEmily Shaffer, Aug 19, 2021
  405. Ævar Arnfjörð BjarmasonAug 24, 2021
  406. Eric SunshineAug 24, 2021
  407. Emily ShafferAug 26, 2021
  408. 3/6 hook: introduce "git hook list"Emily Shaffer, Aug 19, 2021
  409. Ævar Arnfjörð BjarmasonAug 24, 2021
  410. Emily ShafferAug 26, 2021
  411. Ævar Arnfjörð BjarmasonAug 24, 2021
  412. Emily ShafferAug 26, 2021
  413. 4/6 hook: allow running non-native hooksEmily Shaffer, Aug 19, 2021
  414. Ævar Arnfjörð BjarmasonAug 24, 2021
  415. Emily ShafferAug 26, 2021
  416. Junio C HamanoAug 27, 2021
  417. 5/6 hook: include hooks from the configEmily Shaffer, Aug 19, 2021
  418. Junio C HamanoAug 19, 2021
  419. Emily ShafferAug 19, 2021
  420. Junio C HamanoAug 19, 2021
  421. Ævar Arnfjörð BjarmasonAug 24, 2021
  422. Emily ShafferAug 31, 2021
  423. 6/6 hook: allow out-of-repo 'git hook' invocationsEmily Shaffer, Aug 19, 2021
  424. Ævar Arnfjörð BjarmasonAug 24, 2021
  425. Randall S. BeckerAug 24, 2021
  426. Ævar Arnfjörð BjarmasonAug 24, 2021
  427. Emily ShafferAug 31, 2021
  428. Ævar Arnfjörð BjarmasonAug 24, 2021
  429. Emily ShafferSep 2, 2021
  430. 0/5 config-based hooks restartedÆvar Arnfjörð Bjarmason, Sep 9, 2021
  431. 1/5 hook: run a list of hooks insteadÆvar Arnfjörð Bjarmason, Sep 9, 2021
  432. fixup! hook: run a list of hooks insteadÆvar Arnfjörð Bjarmason, Sep 9, 2021
  433. 2/5 hook: allow parallel hook executionÆvar Arnfjörð Bjarmason, Sep 9, 2021
  434. 3/5 hook: introduce "git hook list"Ævar Arnfjörð Bjarmason, Sep 9, 2021
  435. 5/5 hook: allow out-of-repo 'git hook' invocationsÆvar Arnfjörð Bjarmason, Sep 9, 2021
  436. 4/5 hook: include hooks from the configÆvar Arnfjörð Bjarmason, Sep 9, 2021
  437. Emily ShafferAug 19, 2021
  438. Emily ShafferAug 19, 2021
  439. Ævar Arnfjörð BjarmasonSep 2, 2021
  440. 00/36 Run hooks via "git run hook" & hook libraryÆvar Arnfjörð Bjarmason, Sep 2, 2021
  441. 01/36 Makefile: mark "check" target as .PHONYÆvar Arnfjörð Bjarmason, Sep 2, 2021
  442. 02/36 Makefile: stop hardcoding {command,config}-list.hÆvar Arnfjörð Bjarmason, Sep 2, 2021
  443. 03/36 Makefile: remove an out-of-date commentÆvar Arnfjörð Bjarmason, Sep 2, 2021
  444. 04/36 hook.[ch]: move find_hook() from run-command.c to hook.cÆvar Arnfjörð Bjarmason, Sep 2, 2021
  445. 05/36 hook.c: add a hook_exists() wrapper and use it in bugreport.cÆvar Arnfjörð Bjarmason, Sep 2, 2021
  446. 06/36 hook.c users: use "hook_exists()" instead of "find_hook()"Ævar Arnfjörð Bjarmason, Sep 2, 2021
  447. 07/36 hook-list.h: add a generated list of hooks, like config-list.hÆvar Arnfjörð Bjarmason, Sep 2, 2021
  448. 08/36 hook: add 'run' subcommandÆvar Arnfjörð Bjarmason, Sep 2, 2021
  449. 09/36 gc: use hook library for pre-auto-gc hookÆvar Arnfjörð Bjarmason, Sep 2, 2021
  450. 10/36 rebase: convert pre-rebase to use hook.hÆvar Arnfjörð Bjarmason, Sep 2, 2021
  451. 11/36 am: convert applypatch to use hook.hÆvar Arnfjörð Bjarmason, Sep 2, 2021
  452. 12/36 hooks: convert 'post-checkout' hook to hook libraryÆvar Arnfjörð Bjarmason, Sep 2, 2021
  453. 13/36 merge: convert post-merge to use hook.hÆvar Arnfjörð Bjarmason, Sep 2, 2021
  454. 14/36 git hook run: add an --ignore-missing flagÆvar Arnfjörð Bjarmason, Sep 2, 2021
  455. 15/36 send-email: use 'git hook run' for 'sendemail-validate'Ævar Arnfjörð Bjarmason, Sep 2, 2021
  456. 16/36 git-p4: use 'git hook' to run hooksÆvar Arnfjörð Bjarmason, Sep 2, 2021
  457. 17/36 commit: convert {pre-commit,prepare-commit-msg} hook to hook.hÆvar Arnfjörð Bjarmason, Sep 2, 2021
  458. 18/36 read-cache: convert post-index-change to use hook.hÆvar Arnfjörð Bjarmason, Sep 2, 2021
  459. 19/36 receive-pack: convert push-to-checkout hook to hook.hÆvar Arnfjörð Bjarmason, Sep 2, 2021
  460. 20/36 run-command: remove old run_hook_{le,ve}() hook APIÆvar Arnfjörð Bjarmason, Sep 2, 2021
  461. 21/36 run-command: allow stdin for run_processes_parallelÆvar Arnfjörð Bjarmason, Sep 2, 2021
  462. 22/36 hook: support passing stdin to hooksÆvar Arnfjörð Bjarmason, Sep 2, 2021
  463. 23/36 am: convert 'post-rewrite' hook to hook.hÆvar Arnfjörð Bjarmason, Sep 2, 2021
  464. 24/36 run-command: add stdin callback for parallelizationÆvar Arnfjörð Bjarmason, Sep 2, 2021
  465. ab/config-based-hooks-N status (was Re: [PATCH v5 24/36] run-command: add stdin callback for parallelization)Ævar Arnfjörð Bjarmason, Oct 6, 2021
  466. Ævar Arnfjörð BjarmasonOct 12, 2021
  467. 25/36 hook: provide stdin by string_list or callbackÆvar Arnfjörð Bjarmason, Sep 2, 2021
  468. 26/36 hook: convert 'post-rewrite' hook in sequencer.c to hook.hÆvar Arnfjörð Bjarmason, Sep 2, 2021
  469. 28/36 hook tests: test for exact "pre-push" hook inputÆvar Arnfjörð Bjarmason, Sep 2, 2021
  470. 27/36 transport: convert pre-push hook to hook.hÆvar Arnfjörð Bjarmason, Sep 2, 2021
  471. 31/36 run-command: allow capturing of collated outputÆvar Arnfjörð Bjarmason, Sep 2, 2021
  472. 32/36 hooks: allow callers to capture outputÆvar Arnfjörð Bjarmason, Sep 2, 2021
  473. 30/36 reference-transaction: use hook.h to run hooksÆvar Arnfjörð Bjarmason, Sep 2, 2021
  474. 29/36 hook tests: use a modern style for "pre-push" testsÆvar Arnfjörð Bjarmason, Sep 2, 2021
  475. 33/36 receive-pack: convert 'update' hook to hook.hÆvar Arnfjörð Bjarmason, Sep 2, 2021
  476. 34/36 post-update: use hook.h libraryÆvar Arnfjörð Bjarmason, Sep 2, 2021
  477. 35/36 receive-pack: convert receive hooks to hook.hÆvar Arnfjörð Bjarmason, Sep 2, 2021
  478. 36/36 hooks: fix a TOCTOU in "did we run a hook?" heuristicÆvar Arnfjörð Bjarmason, Sep 2, 2021
  479. Felipe ContrerasJun 25, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.