Re: [PATCH v2 01/30] hook: add 'run' subcommand
- From
Felipe Contreras <felipe.contreras@gmail.com>
- Date
- Jun 25, 2021, 19:08 UTC
- Message-ID
- <60d629b28a7ce_cc8d20882@natae.notmuch>
- In-Reply-To
- <YMfLO9CT+iIDR3OA@google.com>
Emily Shaffer wrote:
Show 10 quoted lines
> On Mon, Jun 14, 2021 at 12:32:50PM +0200, Ævar Arnfjörð Bjarmason wrote: > > > > In order to enable hooks to be run as an external process, by a > > standalone Git command, or by tools which wrap Git, provide an external > > means to run all configured hook commands for a given hook event. > > From what it says on the box, I'm slightly worried about this patch > doing too much at once, but let's see... (I think this is also a common > thing you and I disagree on - how much work to do per commit - so feel > free to ignore me ;) )
From my cursory look this is the only big patch, and I trust the reason Ævar made it so big is that he couldn't figure out a way to chop it into smaller pieces that would somehow work.
> > Signed-off-by: Emily Shaffer <emilyshaffer@google.com> > > Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com> > > Thanks for including attribution - I appreciate it.
It's not really an attribution, since he used your code he is pretty much obligated to put your s-o-b, see Developer Certificate of Origin
https://en.wikipedia.org/wiki/Developer_Certificate_of_Origin
-- Felipe Contreras