RE: [PATCH 16/31] receive-pack: convert push-to-checkout hook to hook.h

From: Felipe Contreras <felipe.contreras@gmail.com>
Date: Jun 2, 2021, 00:51 UTC
Message-ID: <60b6d5f985c40_4abd2081a@natae.notmuch>
In-Reply-To: <patch-16.31-a16163d4fb5-20210528T110515Z-avarab@gmail.com>

Ævar Arnfjörð Bjarmason wrote:

Show 10 quoted lines

> From: Emily Shaffer <emilyshaffer@google.com>
> 
> By using hook.h instead of run-command.h to invoke push-to-checkout,
> hooks can now be specified in the config as well as in the hookdir.
> push-to-checkout is not called anywhere but in builtin/receive-pack.c.
> 
> This is the last user of the run_hook_le() API, so let's remove it
> while we're at it, since run_hook_le() itself is the last user of
> run_hook_ve() we can remove that too. The last direct user of
> run_hook_le() was removed in the commit preceding this one.

I think this should be split in two patches.

Yes, fundamentally there's not much of a difference, but if you are already at 31 patches one that removes the last user and nother that removes the API will make the progression a little bit cleaner.

-- 
Felipe Contreras

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.